Re: [dpdk-dev] [PATCH v3] ethdev: fix VLAN offloads set if no driver callback

2020-01-17 Thread Ferruh Yigit
On 1/17/2020 2:31 PM, Ferruh Yigit wrote: > On 1/17/2020 11:49 AM, Wei Hu (Xavier) wrote: >> From: "Wei Hu (Xavier)" >> >> Currently, there is a potential problem that changing the content of >> dev->data->dev_conf.rxmode.offloads even when there is no vlan_offload_set >> driver callback. >> >> It

Re: [dpdk-dev] [PATCH v3] ethdev: fix VLAN offloads set if no driver callback

2020-01-17 Thread Ferruh Yigit
On 1/17/2020 11:49 AM, Wei Hu (Xavier) wrote: > From: "Wei Hu (Xavier)" > > Currently, there is a potential problem that changing the content of > dev->data->dev_conf.rxmode.offloads even when there is no vlan_offload_set > driver callback. > > It is a good idea that prevent the side effect and

[dpdk-dev] [PATCH v3] ethdev: fix VLAN offloads set if no driver callback

2020-01-17 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" Currently, there is a potential problem that changing the content of dev->data->dev_conf.rxmode.offloads even when there is no vlan_offload_set driver callback. It is a good idea that prevent the side effect and make the API return success if no change requested. This pat