[dpdk-dev] [PATCH v3] lib/rte_rib6: fix stack buffer overflow

2021-06-21 Thread ohilyard
From: Owen Hilyard ASAN found a stack buffer overflow in lib/rib/rte_rib6.c:get_dir. The fix for the stack buffer overflow was to make sure depth was always < 128, since when depth = 128 it caused the index into the ip address to be 16, which read off the end of the array. While trying to solve

Re: [dpdk-dev] [PATCH v3] lib/rte_rib6: fix stack buffer overflow

2021-06-22 Thread David Marchand
On Mon, Jun 21, 2021 at 3:28 PM wrote: > > From: Owen Hilyard Hi Owen, Vladimir, Owen, two comments on the patch title. - We (try to) never prefix with lib/, as it gives no additional info. The prefix should be the library name. There were some transgressions to this rule, but this was Thomas

Re: [dpdk-dev] [PATCH v3] lib/rte_rib6: fix stack buffer overflow

2021-06-22 Thread Medvedkin, Vladimir
Hi Owen, David, Apart from David's comments looks good to me. On 22/06/2021 10:10, David Marchand wrote: On Mon, Jun 21, 2021 at 3:28 PM wrote: From: Owen Hilyard Hi Owen, Vladimir, Owen, two comments on the patch title. - We (try to) never prefix with lib/, as it gives no additional

Re: [dpdk-dev] [PATCH v3] lib/rte_rib6: fix stack buffer overflow

2021-06-24 Thread Medvedkin, Vladimir
Acked-by: Vladimir Medvedkin On 21/06/2021 16:28, ohily...@iol.unh.edu wrote: From: Owen Hilyard ASAN found a stack buffer overflow in lib/rib/rte_rib6.c:get_dir. The fix for the stack buffer overflow was to make sure depth was always < 128, since when depth = 128 it caused the index into the