[dpdk-dev] [PATCH v3] mk: fix FreeBSD build

2016-07-21 Thread Thomas Monjalon
> > The sed syntax of '0,/regexp/' is GNU specific and fails with > > non GNU sed in FreeBSD. > > > > To solve the issue we can use awk instead to remove duplicates. > > > > The awk script basically keeps the last config value, while > > maintaining order and comments from original config file. >

[dpdk-dev] [PATCH v3] mk: fix FreeBSD build

2016-07-19 Thread Christian Ehrhardt
Hi, the order changed, but IMHO actually it improved. Things are now at the place they were before, but with the overwriting config value that came later - that is the best of both worlds. Tested a few config runs pre/post patch and compared them sorted (equal) and unsorted - now configs slotted

[dpdk-dev] [PATCH v3] mk: fix FreeBSD build

2016-07-19 Thread Ferruh Yigit
On 7/19/2016 3:30 PM, Christian Ehrhardt wrote: > Hi, > the order changed, but IMHO actually it improved. > Things are now at the place they were before, but with the overwriting > config value that came later - that is the best of both worlds. Agreed, this is a good solution. Also fixes multiple

[dpdk-dev] [PATCH v3] mk: fix FreeBSD build

2016-07-19 Thread Sergio Gonzalez Monroy
The sed syntax of '0,/regexp/' is GNU specific and fails with non GNU sed in FreeBSD. To solve the issue we can use awk instead to remove duplicates. The awk script basically keeps the last config value, while maintaining order and comments from original config file. Fixes: b2063f104db7 ("mk: