Re: [dpdk-dev] [PATCH v3] net/failsafe: fix calling device during RMV events

2017-10-23 Thread Gaëtan Rivet
On Mon, Oct 23, 2017 at 07:17:41AM +, Ophir Munk wrote: > Hi Gaetan, > Thanks for your quick reply. Please see comments inline. > > Regards, > Ophir > > > -Original Message- > > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > > Sent: Friday, October 20, 2017 1:35 PM > > To: Ophir

Re: [dpdk-dev] [PATCH v3] net/failsafe: fix calling device during RMV events

2017-10-23 Thread Ophir Munk
Hi Gaetan, Thanks for your quick reply. Please see comments inline. Regards, Ophir > -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Friday, October 20, 2017 1:35 PM > To: Ophir Munk > Cc: dev@dpdk.org; Thomas Monjalon ; Olga Shern > ; sta...@dpdk.org > Su

Re: [dpdk-dev] [PATCH v3] net/failsafe: fix calling device during RMV events

2017-10-20 Thread Gaëtan Rivet
Hi Ophir, Sorry about the delay, I have a few remarks, I think this patch could be simpler. First, about the commit logline: "calling device" is not descriptive enough. I'd suggest net/failsafe: fix device configuration during RMV events But I'm not a native speaker either, so use it if you

[dpdk-dev] [PATCH v3] net/failsafe: fix calling device during RMV events

2017-10-05 Thread Ophir Munk
This commit prevents control path operations from failing after a sub device removal. Following are the failure steps: 1. The physical device is removed due to change in one of PF parameters (e.g. MTU) 2. The interrupt thread flags the device 3. Within 2 seconds Interrupt thread initializes the ac