Re: [dpdk-dev] [PATCH v3] net/mlx4: fix dev rmv not detected after port stop

2018-02-03 Thread Matan Azrad
Hi Adrien > From: Adrien Mazarguil , Sent: Friday, February 2, 2018 9:53 PM > Hi Matan, > > On Wed, Jan 31, 2018 at 05:07:56PM +, Matan Azrad wrote: > > Hi Adrien > > > > From: Adrien Mazarguil , Sent: Wednesday, January 31, 2018 4:32 PM > > > Hi Matan, > > > > > > On Wed, Jan 31, 2018 at 01:

Re: [dpdk-dev] [PATCH v3] net/mlx4: fix dev rmv not detected after port stop

2018-02-02 Thread Adrien Mazarguil
Hi Matan, On Wed, Jan 31, 2018 at 05:07:56PM +, Matan Azrad wrote: > Hi Adrien > > From: Adrien Mazarguil , Sent: Wednesday, January 31, 2018 4:32 PM > > Hi Matan, > > > > On Wed, Jan 31, 2018 at 01:44:41PM +, Matan Azrad wrote: > > > Hi Adrien > > > I don't know what any application do

Re: [dpdk-dev] [PATCH v3] net/mlx4: fix dev rmv not detected after port stop

2018-01-31 Thread Matan Azrad
Hi Adrien From: Adrien Mazarguil , Sent: Wednesday, January 31, 2018 4:32 PM > Hi Matan, > > On Wed, Jan 31, 2018 at 01:44:41PM +, Matan Azrad wrote: > > Hi Adrien > > > > From: Adrien Mazarguil, Sent: Wednesday, January 31, 2018 12:44 PM > > > On Wed, Jan 31, 2018 at 10:08:06AM +, Matan

Re: [dpdk-dev] [PATCH v3] net/mlx4: fix dev rmv not detected after port stop

2018-01-31 Thread Adrien Mazarguil
Hi Matan, On Wed, Jan 31, 2018 at 01:44:41PM +, Matan Azrad wrote: > Hi Adrien > > From: Adrien Mazarguil, Sent: Wednesday, January 31, 2018 12:44 PM > > On Wed, Jan 31, 2018 at 10:08:06AM +, Matan Azrad wrote: > > > Hi all > > > > > > From: Adrien Mazarguil > > > > On Tue, Jan 30, 2018

Re: [dpdk-dev] [PATCH v3] net/mlx4: fix dev rmv not detected after port stop

2018-01-31 Thread Matan Azrad
Hi Adrien From: Adrien Mazarguil, Sent: Wednesday, January 31, 2018 12:44 PM > On Wed, Jan 31, 2018 at 10:08:06AM +, Matan Azrad wrote: > > Hi all > > > > From: Adrien Mazarguil > > > On Tue, Jan 30, 2018 at 08:37:06PM +, Shahaf Shuler wrote: > > > > Tuesday, January 30, 2018 11:40 AM, Ad

Re: [dpdk-dev] [PATCH v3] net/mlx4: fix dev rmv not detected after port stop

2018-01-31 Thread Adrien Mazarguil
On Wed, Jan 31, 2018 at 10:08:06AM +, Matan Azrad wrote: > Hi all > > From: Adrien Mazarguil > > On Tue, Jan 30, 2018 at 08:37:06PM +, Shahaf Shuler wrote: > > > Tuesday, January 30, 2018 11:40 AM, Adrien Mazarguil: > > > > Unfortunately I didn't get a chance to review this patch before it

Re: [dpdk-dev] [PATCH v3] net/mlx4: fix dev rmv not detected after port stop

2018-01-31 Thread Matan Azrad
Hi all From: Adrien Mazarguil > On Tue, Jan 30, 2018 at 08:37:06PM +, Shahaf Shuler wrote: > > Tuesday, January 30, 2018 11:40 AM, Adrien Mazarguil: > > > Unfortunately I didn't get a chance to review this patch before it was > applied. > > > I'm not sure a stopped port is supposed to report e

Re: [dpdk-dev] [PATCH v3] net/mlx4: fix dev rmv not detected after port stop

2018-01-31 Thread Gaƫtan Rivet
On Wed, Jan 31, 2018 at 10:15:13AM +0100, Adrien Mazarguil wrote: > On Tue, Jan 30, 2018 at 08:37:06PM +, Shahaf Shuler wrote: > > Tuesday, January 30, 2018 11:40 AM, Adrien Mazarguil: > > > Unfortunately I didn't get a chance to review this patch before it was > > > applied. > > > I'm not sur

Re: [dpdk-dev] [PATCH v3] net/mlx4: fix dev rmv not detected after port stop

2018-01-31 Thread Adrien Mazarguil
On Tue, Jan 30, 2018 at 08:37:06PM +, Shahaf Shuler wrote: > Tuesday, January 30, 2018 11:40 AM, Adrien Mazarguil: > > Unfortunately I didn't get a chance to review this patch before it was > > applied. > > I'm not sure a stopped port is supposed to report events (interrupts). Will > > applica

Re: [dpdk-dev] [PATCH v3] net/mlx4: fix dev rmv not detected after port stop

2018-01-30 Thread Shahaf Shuler
Tuesday, January 30, 2018 11:40 AM, Adrien Mazarguil: > Unfortunately I didn't get a chance to review this patch before it was > applied. > I'm not sure a stopped port is supposed to report events (interrupts). Will > applications expect them to occur at this point? Why not? Stopped port is stil

Re: [dpdk-dev] [PATCH v3] net/mlx4: fix dev rmv not detected after port stop

2018-01-30 Thread Adrien Mazarguil
Hi, On Mon, Jan 29, 2018 at 10:54:16AM +, Shahaf Shuler wrote: > Mordechay Haimovsky, Monday, January 29, 2018 10:35 AM: > > In failsafe device start can be called for ports/devices that had been > > plugged > > out. > > The mlx4 PMD detects device removal by listening to the device RMV event

Re: [dpdk-dev] [PATCH v3] net/mlx4: fix dev rmv not detected after port stop

2018-01-29 Thread Shahaf Shuler
Mordechay Haimovsky, Monday, January 29, 2018 10:35 AM: > In failsafe device start can be called for ports/devices that had been plugged > out. > The mlx4 PMD detects device removal by listening to the device RMV events, > when the mlx4 port is being stopped, the PMD no longer listens to these > ev

[dpdk-dev] [PATCH v3] net/mlx4: fix dev rmv not detected after port stop

2018-01-29 Thread Moti Haimovsky
In failsafe device start can be called for ports/devices that had been plugged out. The mlx4 PMD detects device removal by listening to the device RMV events, when the mlx4 port is being stopped, the PMD no longer listens to these events causing the PMD to stop detecting device removals. This patch