[dpdk-dev] [PATCH v3] pipeline: add statistics for librte_pipeline

2015-05-27 Thread Rajagopalan Sivaramakrishnan
> > You also reiterate that you would like to have the stats always enabled. You > can definitely do this, it is one of the available choices, but why not also > accommodate the users that want to pick the opposite choice? Why force > apps to spend cycles on stats if the app either does not want t

[dpdk-dev] [PATCH v3] pipeline: add statistics for librte_pipeline

2015-05-28 Thread Dumitrescu, Cristian
. Regards, Cristian > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Rajagopalan > Sivaramakrishnan > Sent: Wednesday, May 27, 2015 11:45 PM > To: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] pipeline: add statistics for > librte_pip

[dpdk-dev] [PATCH v3] pipeline: add statistics for librte_pipeline

2015-05-28 Thread Rajagopalan Sivaramakrishnan
t now is reaching a conclusion on this item as soon as we can. > >Regards, >Cristian > > > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Rajagopalan >> Sivaramakrishnan >> Sent: Wednesday, May 27, 2015 11:45 PM >

[dpdk-dev] [PATCH v3] pipeline: add statistics for librte_pipeline

2015-05-29 Thread Ramia, Kannan Babu
: Rajagopalan Sivaramakrishnan; dev at dpdk.org Subject: Re: [dpdk-dev] [PATCH v3] pipeline: add statistics for librte_pipeline Hi Raja, Thanks for your input. I think we have the following options identified so far for stats collection configuration: 1. Stats configuration through the

[dpdk-dev] [PATCH v3] pipeline: add statistics for librte_pipeline

2015-06-05 Thread Thomas Monjalon
2015-05-28 19:26, Dumitrescu, Cristian: > I think we have the following options identified so far for stats collection > configuration: > > 1. Stats configuration through the RTE_LOG_LEVEL > 2. Single configuration flag global for all DPDK libraries > 3. Single configuration flag per DPDK library

[dpdk-dev] [PATCH v3] pipeline: add statistics for librte_pipeline ports and tables

2015-05-26 Thread Maciej Gajdzica
This patch adds statistics collection for librte_pipeline. Those statistics ale disabled by default during build time. Signed-off-by: Pawel Wodkowski --- lib/librte_pipeline/rte_pipeline.c | 185 +--- lib/librte_pipeline/rte_pipeline.h | 98 +++

[dpdk-dev] [PATCH v3] pipeline: add statistics for librte_pipeline ports and tables

2015-05-26 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Maciej Gajdzica > Sent: Tuesday, May 26, 2015 2:39 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v3] pipeline: add statistics for librte_pipeline > ports and tables > > Th

[dpdk-dev] [PATCH v3] pipeline: add statistics for librte_pipeline ports and tables

2015-05-26 Thread Stephen Hemminger
On Tue, 26 May 2015 15:39:18 +0200 Maciej Gajdzica wrote: > +#if RTE_LOG_LEVEL == RTE_LOG_DEBUG > +#define RTE_PIPELINE_STATS_ADD(counter, val) \ > + ({ (counter) += (val); }) > + > +#define RTE_PIPELINE_STATS_ADD_M(counter, mask) \ > + ({ (counter) += __builtin_popcountll(mask); }) > +#e

[dpdk-dev] [PATCH v3] pipeline: add statistics for librte_pipeline ports and tables

2015-05-26 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stephen > Hemminger > Sent: Tuesday, May 26, 2015 3:57 PM > To: Gajdzica, MaciejX T > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] pipeline: add statistics for > librte_pip

[dpdk-dev] [PATCH v3] pipeline: add statistics for librte_pipeline ports and tables

2015-05-26 Thread Stephen Hemminger
iejX T > > Cc: dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v3] pipeline: add statistics for > > librte_pipeline > > ports and tables > > > > On Tue, 26 May 2015 15:39:18 +0200 > > Maciej Gajdzica wrote: > > > > > +#if RTE_LOG_LE

[dpdk-dev] [PATCH v3] pipeline: add statistics for librte_pipeline ports and tables

2015-05-26 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Tuesday, May 26, 2015 10:48 PM > To: Dumitrescu, Cristian > Cc: Gajdzica, MaciejX T; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] pipeline: add statistics for > li

[dpdk-dev] [PATCH v3] pipeline: add statistics for librte_pipeline ports and tables

2015-05-27 Thread Thomas Monjalon
2015-05-26 07:57, Stephen Hemminger: > On Tue, 26 May 2015 15:39:18 +0200 > Maciej Gajdzica wrote: > > > +#if RTE_LOG_LEVEL == RTE_LOG_DEBUG > > +#define RTE_PIPELINE_STATS_ADD(counter, val) \ > > + ({ (counter) += (val); }) > > + > > +#define RTE_PIPELINE_STATS_ADD_M(counter, mask) \ > > + (