Re: [dpdk-dev] [PATCH v3] tests/cmdline: fix memory leaks

2021-06-24 Thread David Marchand
On Wed, Jun 23, 2021 at 8:06 PM wrote: > > From: Owen Hilyard > > Fixes for a few memory leaks in the cmdline_autotest unit test. > > All of the leaks were related to not freeing the commandline struct > after testing had completed. > > Fixes: dbb860e03e ("cmdline: tests") Updated sha1. Cc: sta..

Re: [dpdk-dev] [PATCH v3] tests/cmdline: fix memory leaks

2021-06-24 Thread David Marchand
On Thu, Jun 24, 2021 at 2:08 PM Olivier Matz wrote: > > - if (cmdline_file_new(&ctx, "prompt", "/dev/null") == NULL) { > > + cl = cmdline_file_new(&ctx, "prompt", "/dev/null"); > > + if (cl == NULL) { > > printf("Error: failed to open /dev/null for reading!"); > > +

Re: [dpdk-dev] [PATCH v3] tests/cmdline: fix memory leaks

2021-06-24 Thread Olivier Matz
Hi Owen, One small issue remain, please see below. On Wed, Jun 23, 2021 at 02:06:45PM -0400, ohily...@iol.unh.edu wrote: > From: Owen Hilyard > > Fixes for a few memory leaks in the cmdline_autotest unit test. > > All of the leaks were related to not freeing the commandline struct > after test

[dpdk-dev] [PATCH v3] tests/cmdline: fix memory leaks

2021-06-23 Thread ohilyard
From: Owen Hilyard Fixes for a few memory leaks in the cmdline_autotest unit test. All of the leaks were related to not freeing the commandline struct after testing had completed. Fixes: dbb860e03e ("cmdline: tests") Signed-off-by: Owen Hilyard Reviewed-by: David Marchand --- app/test/test_