Re: [dpdk-dev] [PATCH v3] vhost: add header check in dequeue offload

2021-05-07 Thread Wang, Xiao W
Hi Maxime and David, I see patch " vhost: fix offload flags in Rx path " http://patches.dpdk.org/project/dpdk/patch/20210503164344.27916-4-david.march...@redhat.com/ has been merged, and the legacy implementation is kept. Do you think we still need to fix the header check for the legacy impleme

Re: [dpdk-dev] [PATCH v3] vhost: add header check in dequeue offload

2021-04-13 Thread Maxime Coquelin
On 4/12/21 11:33 AM, David Marchand wrote: > On Mon, Apr 12, 2021 at 11:09 AM Wang, Xiao W wrote: >> Considering the major consumer of vhost API is virtual switch/router, I tend >> to keep the current implementation and apply this fix patch. >> Any comments? > > This is just a hack that bypas

Re: [dpdk-dev] [PATCH v3] vhost: add header check in dequeue offload

2021-04-12 Thread David Marchand
On Mon, Apr 12, 2021 at 11:09 AM Wang, Xiao W wrote: > Considering the major consumer of vhost API is virtual switch/router, I tend > to keep the current implementation and apply this fix patch. > Any comments? This is just a hack that bypasses the vswitch control. It happens to work when the v

Re: [dpdk-dev] [PATCH v3] vhost: add header check in dequeue offload

2021-04-12 Thread Wang, Xiao W
Hi, > -Original Message- > From: Wang, Xiao W > Sent: Friday, April 2, 2021 4:39 PM > To: David Marchand > Cc: Xia, Chenbo ; Maxime Coquelin > ; Liu, Yong ; dev > ; Ananyev, Konstantin ; > dpdk stable ; yangy...@inspur.com > Subject: RE: [PATCH v3] vhost: add header check in dequeue offlo

Re: [dpdk-dev] [PATCH v3] vhost: add header check in dequeue offload

2021-04-02 Thread Wang, Xiao W
> -Original Message- > From: David Marchand > Sent: Thursday, April 1, 2021 8:04 PM > To: Wang, Xiao W > Cc: Xia, Chenbo ; Maxime Coquelin > ; Liu, Yong ; dev > ; Ananyev, Konstantin ; > dpdk stable > Subject: Re: [PATCH v3] vhost: add header check in dequeue offload > > On Wed, Mar 17

Re: [dpdk-dev] [PATCH v3] vhost: add header check in dequeue offload

2021-04-01 Thread David Marchand
On Wed, Mar 17, 2021 at 7:50 AM Xiao Wang wrote: > > When parsing the virtio net header and packet header for dequeue offload, > we need to perform sanity check on the packet header to ensure: > - No out-of-boundary memory access. > - The packet header and virtio_net header are valid and align

[dpdk-dev] [PATCH v3] vhost: add header check in dequeue offload

2021-03-16 Thread Xiao Wang
When parsing the virtio net header and packet header for dequeue offload, we need to perform sanity check on the packet header to ensure: - No out-of-boundary memory access. - The packet header and virtio_net header are valid and aligned. Fixes: d0cf91303d73 ("vhost: add Tx offload capabilitie