Re: [dpdk-dev] [PATCH v3 0/4] add checking of header includes

2021-01-26 Thread Thomas Monjalon
26/01/2021 16:42, Bruce Richardson: > On Tue, Jan 26, 2021 at 04:31:36PM +0100, Thomas Monjalon wrote: > > 26/01/2021 15:39, Bruce Richardson: > > > Removing the ALLOW_INTERNAL_API is probably a good idea, but it does > > > indeed > > > throw up the errors with clang - but not gcc, which is strang

Re: [dpdk-dev] [PATCH v3 0/4] add checking of header includes

2021-01-26 Thread Bruce Richardson
On Tue, Jan 26, 2021 at 04:31:36PM +0100, Thomas Monjalon wrote: > 26/01/2021 15:39, Bruce Richardson: > > Removing the ALLOW_INTERNAL_API is probably a good idea, but it does indeed > > throw up the errors with clang - but not gcc, which is strange. The > > offending headers seem to be (initially)

Re: [dpdk-dev] [PATCH v3 0/4] add checking of header includes

2021-01-26 Thread Thomas Monjalon
26/01/2021 15:39, Bruce Richardson: > Removing the ALLOW_INTERNAL_API is probably a good idea, but it does indeed > throw up the errors with clang - but not gcc, which is strange. The > offending headers seem to be (initially): > > * rte_ethdev_vdev.h > * rte_ethdev_pci.h > > Are these public hea

Re: [dpdk-dev] [PATCH v3 0/4] add checking of header includes

2021-01-26 Thread Bruce Richardson
On Tue, Jan 26, 2021 at 02:24:02PM +, Bruce Richardson wrote: > On Tue, Jan 26, 2021 at 03:04:25PM +0100, David Marchand wrote: > > On Tue, Jan 26, 2021 at 12:15 PM Bruce Richardson > > wrote: > > > > > > On Mon, Jan 25, 2021 at 04:51:19PM +0100, David Marchand wrote: > > > > On Mon, Jan 25, 2

Re: [dpdk-dev] [PATCH v3 0/4] add checking of header includes

2021-01-26 Thread Bruce Richardson
On Tue, Jan 26, 2021 at 03:04:25PM +0100, David Marchand wrote: > On Tue, Jan 26, 2021 at 12:15 PM Bruce Richardson > wrote: > > > > On Mon, Jan 25, 2021 at 04:51:19PM +0100, David Marchand wrote: > > > On Mon, Jan 25, 2021 at 3:11 PM Bruce Richardson > > > wrote: > > > > > > > > As a general pri

Re: [dpdk-dev] [PATCH v3 0/4] add checking of header includes

2021-01-26 Thread David Marchand
On Tue, Jan 26, 2021 at 12:15 PM Bruce Richardson wrote: > > On Mon, Jan 25, 2021 at 04:51:19PM +0100, David Marchand wrote: > > On Mon, Jan 25, 2021 at 3:11 PM Bruce Richardson > > wrote: > > > > > > As a general principle, each header file should include any other > > > headers it needs to prov

Re: [dpdk-dev] [PATCH v3 0/4] add checking of header includes

2021-01-26 Thread Bruce Richardson
On Mon, Jan 25, 2021 at 04:51:19PM +0100, David Marchand wrote: > On Mon, Jan 25, 2021 at 3:11 PM Bruce Richardson > wrote: > > > > As a general principle, each header file should include any other > > headers it needs to provide data type definitions or macros. For > > example, any header using t

Re: [dpdk-dev] [PATCH v3 0/4] add checking of header includes

2021-01-25 Thread Bruce Richardson
On Mon, Jan 25, 2021 at 04:51:19PM +0100, David Marchand wrote: > On Mon, Jan 25, 2021 at 3:11 PM Bruce Richardson > wrote: > > > > As a general principle, each header file should include any other > > headers it needs to provide data type definitions or macros. For > > example, any header using t

Re: [dpdk-dev] [PATCH v3 0/4] add checking of header includes

2021-01-25 Thread David Marchand
On Mon, Jan 25, 2021 at 3:11 PM Bruce Richardson wrote: > > As a general principle, each header file should include any other > headers it needs to provide data type definitions or macros. For > example, any header using the uintX_t types in structures or function > prototypes should include "stdi

[dpdk-dev] [PATCH v3 0/4] add checking of header includes

2021-01-25 Thread Bruce Richardson
As a general principle, each header file should include any other headers it needs to provide data type definitions or macros. For example, any header using the uintX_t types in structures or function prototypes should include "stdint.h" to provide those type definitions. In practice, while many,