[dpdk-dev] [PATCH v3 02/12] hash: fix compilation on non-X86 platforms

2015-07-08 Thread Tony Lu
>-Original Message- >From: Sanford, Robert [mailto:rsanford at akamai.com] >Sent: Tuesday, July 07, 2015 10:52 PM >To: Zhigang Lu; dev at dpdk.org >Subject: Re: [dpdk-dev] [PATCH v3 02/12] hash: fix compilation on non-X86 >platforms > >Hi Zhigang, > >Can yo

[dpdk-dev] [PATCH v3 02/12] hash: fix compilation on non-X86 platforms

2015-07-07 Thread Tony Lu
>-Original Message- >From: Bruce Richardson [mailto:bruce.richardson at intel.com] >Sent: Monday, July 06, 2015 7:15 PM >To: Zhigang Lu >Cc: dev at dpdk.org >Subject: Re: [dpdk-dev] [PATCH v3 02/12] hash: fix compilation on non-X86 >platforms > >On Mon, Jul 0

[dpdk-dev] [PATCH v3 02/12] hash: fix compilation on non-X86 platforms

2015-07-07 Thread Sanford, Robert
Hi Zhigang, Can you add this one-line X86 change (below)? When included by C++ code, 'key' needs an explicit type cast. You may want to put the 'const' keyword in your non-X86 change, too. -- Thanks, Robert diff --git a/lib/librte_hash/rte_jhash.h b/lib/librte_hash/rte_jhash.h index e230449.

[dpdk-dev] [PATCH v3 02/12] hash: fix compilation on non-X86 platforms

2015-07-06 Thread Zhigang Lu
The "hash: remove duplicated code" change unfortunately broke the build for non-X86 platforms. This patch fixes this breakage. Change-Id: Ie109d67e681b75b45320fab1bf9de4eb9c9701bf Signed-off-by: Zhigang Lu --- lib/librte_hash/rte_jhash.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[dpdk-dev] [PATCH v3 02/12] hash: fix compilation on non-X86 platforms

2015-07-06 Thread Bruce Richardson
On Mon, Jul 06, 2015 at 04:51:27PM +0800, Zhigang Lu wrote: > The "hash: remove duplicated code" change unfortunately broke the > build for non-X86 platforms. This patch fixes this breakage. > Fixes: 49361c3f3cfa ("hash: remove duplicated code") > Change-Id: Ie109d67e681b75b45320fab1bf9de4eb9c97