Re: [dpdk-dev] [PATCH v3 03/10] net/atlantic: extra checks for error codes

2019-03-20 Thread Igor Russkikh
Hi Ferruh, Sorry forgot that. Coverity issue: 187034 On 20.03.2019 16:24, Ferruh Yigit wrote: > On 3/12/2019 3:24 PM, Igor Russkikh wrote: >> Found by Coverity scan. Checks are useless >> because at these code places err is always zero. > > Can you please add Coverity issue number, I can squash

Re: [dpdk-dev] [PATCH v3 03/10] net/atlantic: extra checks for error codes

2019-03-20 Thread Ferruh Yigit
On 3/12/2019 3:24 PM, Igor Russkikh wrote: > Found by Coverity scan. Checks are useless > because at these code places err is always zero. Can you please add Coverity issue number, I can squash it later. > > Signed-off-by: Igor Russkikh > --- <...>

[dpdk-dev] [PATCH v3 03/10] net/atlantic: extra checks for error codes

2019-03-12 Thread Igor Russkikh
Found by Coverity scan. Checks are useless because at these code places err is always zero. Signed-off-by: Igor Russkikh --- drivers/net/atlantic/hw_atl/hw_atl_utils.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/atlantic/hw_atl/hw_atl_utils.c b/drivers/ne