Re: [dpdk-dev] [PATCH v3 04/10] app/testpmd: convert to new Ethdev Tx offloads API

2018-01-09 Thread Lu, Wenzhuo
Hi Konstantin, > -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, January 9, 2018 8:15 PM > To: Lu, Wenzhuo ; Shahaf Shuler > ; Wu, Jingjing ; Yigit, > Ferruh > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v3 04/10] app/testpmd: convert to new

Re: [dpdk-dev] [PATCH v3 04/10] app/testpmd: convert to new Ethdev Tx offloads API

2018-01-09 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Lu, Wenzhuo > Sent: Tuesday, January 9, 2018 11:37 AM > To: Shahaf Shuler ; Wu, Jingjing > ; Yigit, Ferruh > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 04/10] app/testpmd: conver

Re: [dpdk-dev] [PATCH v3 04/10] app/testpmd: convert to new Ethdev Tx offloads API

2018-01-09 Thread Lu, Wenzhuo
Hi Shahaf, > -Original Message- > From: Shahaf Shuler [mailto:shah...@mellanox.com] > Sent: Tuesday, January 9, 2018 6:02 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Yigit, Ferruh > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v3 04/10] app/testpmd: convert to new

Re: [dpdk-dev] [PATCH v3 04/10] app/testpmd: convert to new Ethdev Tx offloads API

2018-01-09 Thread Shahaf Shuler
Tuesday, January 9, 2018 9:14 AM, Lu, Wenzhuo: > > The original code doesn't have such restriction because testpmd wasn't > > configuring Tx offloads at all. It used it's own Tx offloads enum > > (which I removed on later patches) to indicate which offloads is set. > > From the device perspective a

Re: [dpdk-dev] [PATCH v3 04/10] app/testpmd: convert to new Ethdev Tx offloads API

2018-01-08 Thread Lu, Wenzhuo
6, 2017 5:44 PM > > > To: Wu, Jingjing ; Yigit, Ferruh > > > > > > Cc: dev@dpdk.org > > > Subject: [dpdk-dev] [PATCH v3 04/10] app/testpmd: convert to new > > > Ethdev Tx offloads API > > > > > > Ethdev Tx offloads API has changed

Re: [dpdk-dev] [PATCH v3 04/10] app/testpmd: convert to new Ethdev Tx offloads API

2018-01-08 Thread Shahaf Shuler
; > Cc: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH v3 04/10] app/testpmd: convert to new > > Ethdev Tx offloads API > > > > Ethdev Tx offloads API has changed since: > > > > commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") > > >

Re: [dpdk-dev] [PATCH v3 04/10] app/testpmd: convert to new Ethdev Tx offloads API

2018-01-08 Thread Lu, Wenzhuo
Hi Shahaf, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shahaf Shuler > Sent: Tuesday, December 26, 2017 5:44 PM > To: Wu, Jingjing ; Yigit, Ferruh > > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v3 04/10] app/testpmd: convert to new

[dpdk-dev] [PATCH v3 04/10] app/testpmd: convert to new Ethdev Tx offloads API

2017-12-26 Thread Shahaf Shuler
Ethdev Tx offloads API has changed since: commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") Convert the application to use the new API. This patch mandates the port to be stopped when configure the Tx offloads. This is because the PMD must be aware to the offloads changes on the de