Re: [dpdk-dev] [PATCH v3 08/10] eal/windows: fix rte_page_sizes with Clang on Windows

2020-05-05 Thread Ray Kinsella
On 15/04/2020 12:17, Jerin Jacob wrote: > On Wed, Apr 15, 2020 at 4:39 PM Dmitry Kozlyuk > wrote: >> >> >> >>> On Wed, Apr 15, 2020 at 4:02 PM Dmitry Kozlyuk >>> wrote: > On Wed, Apr 15, 2020 at 1:16 AM Dmitry Kozlyuk > wrote: >> >> Clang on Windows follows MS ABI wher

Re: [dpdk-dev] [PATCH v3 08/10] eal/windows: fix rte_page_sizes with Clang on Windows

2020-04-15 Thread Jerin Jacob
On Wed, Apr 15, 2020 at 4:39 PM Dmitry Kozlyuk wrote: > > > > > On Wed, Apr 15, 2020 at 4:02 PM Dmitry Kozlyuk > > wrote: > > > > > > > On Wed, Apr 15, 2020 at 1:16 AM Dmitry Kozlyuk > > > > wrote: > > > > > > > > > > Clang on Windows follows MS ABI where enum values are limited to > > > > >

Re: [dpdk-dev] [PATCH v3 08/10] eal/windows: fix rte_page_sizes with Clang on Windows

2020-04-15 Thread Dmitry Kozlyuk
> On Wed, Apr 15, 2020 at 4:02 PM Dmitry Kozlyuk > wrote: > > > > > On Wed, Apr 15, 2020 at 1:16 AM Dmitry Kozlyuk > > > wrote: > > > > > > > > Clang on Windows follows MS ABI where enum values are limited to 2^31-1. > > > > Enum rte_page_size has members valued above this limit, which g

Re: [dpdk-dev] [PATCH v3 08/10] eal/windows: fix rte_page_sizes with Clang on Windows

2020-04-15 Thread Jerin Jacob
On Wed, Apr 15, 2020 at 4:02 PM Dmitry Kozlyuk wrote: > > > On Wed, Apr 15, 2020 at 1:16 AM Dmitry Kozlyuk > > wrote: > > > > > > Clang on Windows follows MS ABI where enum values are limited to 2^31-1. > > > Enum rte_page_size has members valued above this limit, which get > > > wrapped to zero

Re: [dpdk-dev] [PATCH v3 08/10] eal/windows: fix rte_page_sizes with Clang on Windows

2020-04-15 Thread Dmitry Kozlyuk
> On Wed, Apr 15, 2020 at 1:16 AM Dmitry Kozlyuk > wrote: > > > > Clang on Windows follows MS ABI where enum values are limited to 2^31-1. > > Enum rte_page_size has members valued above this limit, which get > > wrapped to zero, resulting in compilation error (duplicate values in > > enum). Usin

Re: [dpdk-dev] [PATCH v3 08/10] eal/windows: fix rte_page_sizes with Clang on Windows

2020-04-15 Thread Jerin Jacob
On Wed, Apr 15, 2020 at 1:16 AM Dmitry Kozlyuk wrote: > > Clang on Windows follows MS ABI where enum values are limited to 2^31-1. > Enum rte_page_size has members valued above this limit, which get > wrapped to zero, resulting in compilation error (duplicate values in > enum). Using MS ABI is man

[dpdk-dev] [PATCH v3 08/10] eal/windows: fix rte_page_sizes with Clang on Windows

2020-04-14 Thread Dmitry Kozlyuk
Clang on Windows follows MS ABI where enum values are limited to 2^31-1. Enum rte_page_size has members valued above this limit, which get wrapped to zero, resulting in compilation error (duplicate values in enum). Using MS ABI is mandatory for Windows EAL to call Win32 APIs. Define these values o