Re: [dpdk-dev] [PATCH v3 1/2] eal/windows: add pthread mutex lock

2020-10-14 Thread Tal Shnaiderman
Hi DmitryM, Naty, We would like to know if the macro added below for PTHREAD_MUTEX_INITIALIZER is a safe initialization of a CRITICAL_SECTION. Can you please review the code and explanation below and check it internally? > Subject: Re: [dpdk-dev] [PATCH v3 1/2] eal/windows: add pthread mu

Re: [dpdk-dev] [PATCH v3 1/2] eal/windows: add pthread mutex lock

2020-10-07 Thread Suanming Mou
Hi Dmitry, Thank you very much. I also got some messages that they wish the PTHREAD_MUTEX_INITIALIZER macro can also be supported. Refer to [1], we found that with critical section solution, maybe the macro can be defined as this: #define PTHREAD_MUTEX_INITIALIZER {(void*)-1,-1,0,0,0,0} We hav

Re: [dpdk-dev] [PATCH v3 1/2] eal/windows: add pthread mutex lock

2020-10-07 Thread Dmitry Kozlyuk
On Wed, 7 Oct 2020 22:17:28 +0800, Suanming Mou wrote: > Add pthread mutex lock as it is needed for the thread safe rte_flow > functions. > > Signed-off-by: Suanming Mou Acked-by: Dmitry Kozlyuk

[dpdk-dev] [PATCH v3 1/2] eal/windows: add pthread mutex lock

2020-10-07 Thread Suanming Mou
Add pthread mutex lock as it is needed for the thread safe rte_flow functions. Signed-off-by: Suanming Mou --- v3: - No updates. v2: - Using critical section for windows pthread mutex. --- lib/librte_eal/windows/include/pthread.h | 33 1 file changed, 33 in