[dpdk-dev] [PATCH v3 1/2] ethdev: add callback to get register size in bytes

2016-06-22 10:19, Zyta Szpak: > Note that if we remove rte_eth_dev_get_reg_length() then it will break > all of the drivers that implement it. Shall I remove it all leave it and > modify only ethtool to use rte_eth_dev_get_regs() to get reg size? In > the end the drivers will have to implement

[dpdk-dev] [PATCH v3 1/2] ethdev: add callback to get register size in bytes

Note that if we remove rte_eth_dev_get_reg_length() then it will break all of the drivers that implement it. Shall I remove it all leave it and modify only ethtool to use rte_eth_dev_get_regs() to get reg size? In the end the drivers will have to implement the part of setting the size in

[dpdk-dev] [PATCH v3 1/2] ethdev: add callback to get register size in bytes

OK, I will do the v4. On 17.06.2016 12:20, Thomas Monjalon wrote: > 2016-06-13 16:51, Remy Horton: >> On 12/06/2016 15:51, Zyta Szpak wrote: >>> I would prefer having only one function rte_eth_dev_get_regs() >>> which returns length and width if data is NULL. >>> The first call is

[dpdk-dev] [PATCH v3 1/2] ethdev: add callback to get register size in bytes

2016-06-13 16:51, Remy Horton: > > On 12/06/2016 15:51, Zyta Szpak wrote: > > I would prefer having only one function rte_eth_dev_get_regs() > > which returns length and width if data is NULL. > > The first call is a parameter request before buffer allocation, > > and the second

[dpdk-dev] [PATCH v3 1/2] ethdev: add callback to get register size in bytes

On 12/06/2016 15:51, Zyta Szpak wrote: > I would prefer having only one function rte_eth_dev_get_regs() > which returns length and width if data is NULL. > The first call is a parameter request before buffer allocation, > and the second call fills the buffer. > > We can

[dpdk-dev] [PATCH v3 1/2] ethdev: add callback to get register size in bytes

Hi, please see inline 2016-06-08 10:53 GMT+02:00 Thomas Monjalon : > Hi Zyta, > > 2016-06-01 09:56, zr at semihalf.com: > > rte_eth_dev_get_reg_length and rte_eth_dev_get_reg callbacks > > do not provide register size to the app in any way. It is > > needed to allocate proper number of bytes

[dpdk-dev] [PATCH v3 1/2] ethdev: add callback to get register size in bytes

Hi Zyta, 2016-06-01 09:56, zr at semihalf.com: > rte_eth_dev_get_reg_length and rte_eth_dev_get_reg callbacks > do not provide register size to the app in any way. It is > needed to allocate proper number of bytes before retrieving > registers content with rte_eth_dev_get_reg. Yes, register size

[dpdk-dev] [PATCH v3 1/2] ethdev: add callback to get register size in bytes

On 01/06/2016 08:56, zr at semihalf.com wrote: > From: Zyta Szpak > > Version 2 of fixing the fixed register width assumption. > rte_eth_dev_get_reg_length and rte_eth_dev_get_reg callbacks > do not provide register size to the app in any way. It is > needed to allocate proper number of bytes

[dpdk-dev] [PATCH v3 1/2] ethdev: add callback to get register size in bytes

From: Zyta Szpak Version 2 of fixing the fixed register width assumption. rte_eth_dev_get_reg_length and rte_eth_dev_get_reg callbacks do not provide register size to the app in any way. It is needed to allocate proper number of bytes before retrieving registers content with