Re: [dpdk-dev] [PATCH v3 1/2] ethdev: introduce Rx queue offloads API

2017-09-13 Thread Shahaf Shuler
Wednesday, September 13, 2017 11:13 AM, Andrew Rybchenko: On 09/13/2017 09:37 AM, Shahaf Shuler wrote: >I think it would be useful to have the description in the documentation. >It is really important topic on how per-port and per-queue offloads coexist >and rules should be 100% clear for PMD main

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: introduce Rx queue offloads API

2017-09-13 Thread Andrew Rybchenko
On 09/13/2017 03:33 PM, Shahaf Shuler wrote: Wednesday, September 13, 2017 12:13 PM, Andrew Rybchenko: >>return -EBUSY; >>  } >>  +    /* >>+ * Convert between the offloads API to enable PMDs to support >>+ * only one of them.

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: introduce Rx queue offloads API

2017-09-13 Thread Shahaf Shuler
Wednesday, September 13, 2017 12:13 PM, Andrew Rybchenko: >>return -EBUSY; >> } >> +/* >>+ * Convert between the offloads API to enable PMDs to support >>+ * only one of them. >>+ */ >>+if ((dev_conf->rxmode.ignore_offload_bitfield == 0)) { >>+rte_eth_convert_rx_of

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: introduce Rx queue offloads API

2017-09-13 Thread Andrew Rybchenko
On 09/13/2017 11:49 AM, Andrew Rybchenko wrote: On 09/13/2017 09:37 AM, Shahaf Shuler wrote: Introduce a new API to configure Rx offloads. In the new API, offloads are divided into per-port and per-queue offloads. The PMD reports capability for each of them. Offloads are enabled using the exist

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: introduce Rx queue offloads API

2017-09-13 Thread Andrew Rybchenko
On 09/13/2017 09:37 AM, Shahaf Shuler wrote: Introduce a new API to configure Rx offloads. In the new API, offloads are divided into per-port and per-queue offloads. The PMD reports capability for each of them. Offloads are enabled using the existing DEV_RX_OFFLOAD_* flags. To enable per-port of

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: introduce Rx queue offloads API

2017-09-13 Thread Andrew Rybchenko
On 09/13/2017 09:37 AM, Shahaf Shuler wrote: Introduce a new API to configure Rx offloads. In the new API, offloads are divided into per-port and per-queue offloads. The PMD reports capability for each of them. Offloads are enabled using the existing DEV_RX_OFFLOAD_* flags. To enable per-port of

[dpdk-dev] [PATCH v3 1/2] ethdev: introduce Rx queue offloads API

2017-09-12 Thread Shahaf Shuler
Introduce a new API to configure Rx offloads. In the new API, offloads are divided into per-port and per-queue offloads. The PMD reports capability for each of them. Offloads are enabled using the existing DEV_RX_OFFLOAD_* flags. To enable per-port offload, the offload should be set on both device