Re: [dpdk-dev] [PATCH v3 1/2] ethdev: queue release callback optional

2021-09-17 Thread Xueming(Steven) Li
On Fri, 2021-09-17 at 14:53 +0300, Andrew Rybchenko wrote: > On 9/17/21 2:29 PM, Andrew Rybchenko wrote: > > On 9/17/21 12:39 PM, Xueming Li wrote: > > > Some drivers don't need Rx and Tx queue release callback, make it > > > optional. > > > > > > Signed-off-by: Xueming Li > > > > LGTM, but plea

[dpdk-dev] [PATCH v3 1/2] ethdev: queue release callback optional

2021-09-17 Thread Xueming Li
Some drivers don't need Rx and Tx queue release callback, make it optional. Signed-off-by: Xueming Li --- lib/ethdev/rte_ethdev.c | 48 + 1 file changed, 20 insertions(+), 28 deletions(-) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c inde

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: queue release callback optional

2021-09-17 Thread Andrew Rybchenko
On 9/17/21 2:29 PM, Andrew Rybchenko wrote: > On 9/17/21 12:39 PM, Xueming Li wrote: >> Some drivers don't need Rx and Tx queue release callback, make it >> optional. >> >> Signed-off-by: Xueming Li > > LGTM, but please, consider one nit below > > Reviewed-by: Andrew Rybchenko > >> --- >> lib

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: queue release callback optional

2021-09-17 Thread Andrew Rybchenko
On 9/17/21 12:39 PM, Xueming Li wrote: > Some drivers don't need Rx and Tx queue release callback, make it > optional. > > Signed-off-by: Xueming Li LGTM, but please, consider one nit below Reviewed-by: Andrew Rybchenko > --- > lib/ethdev/rte_ethdev.c | 48 +--