Re: [dpdk-dev] [PATCH v3 1/3] eal/linux: make hugetlbfs analysis reusable

On Tue, Sep 14, 2021 at 01:34:54PM +0300, Dmitry Kozlyuk wrote: > + do { > + m = getmntent(f); Should you be using getmntent_r() etc? Nice cleanup! regards john

Re: [dpdk-dev] [PATCH v3 1/3] eal/linux: make hugetlbfs analysis reusable

> -Original Message- > From: John Levon > Sent: 14 сентября 2021 г. 15:48 > To: Dmitry Kozlyuk > Cc: dev@dpdk.org; Anatoly Burakov ; Slava > Ovsiienko > Subject: Re: [PATCH v3 1/3] eal/linux: make hugetlbfs analysis reusable > > External email: Use caution opening links or attachments >

[dpdk-dev] [PATCH v3 1/3] eal/linux: make hugetlbfs analysis reusable

get_hugepage_dir() searched for a hugetlbfs mount with a given page size using handcraft parsing of /proc/mounts and mixing traversal logic with selecting the needed entry. Separate code to enumerate hugetlbfs mounts to eal_hugepage_mount_walk() taking a callback that can inspect already parsed ent

Re: [dpdk-dev] [PATCH v3 1/3] eal/linux: make hugetlbfs analysis reusable

On Tue, Sep 14, 2021 at 01:34:54PM +0300, Dmitry Kozlyuk wrote: > get_hugepage_dir() searched for a hugetlbfs mount with a given page size > using handcraft parsing of /proc/mounts and mixing traversal logic with > selecting the needed entry. Separate code to enumerate hugetlbfs mounts > to eal_hu