Re: [dpdk-dev] [PATCH v3 1/3] net: fix s_addr redefinition in Windows

2020-07-14 Thread Fady Bader
> -Original Message- > From: Olivier Matz > Sent: Monday, July 13, 2020 5:39 PM > To: Fady Bader > Cc: dev@dpdk.org; Thomas Monjalon ; Tasnim Bashar > ; Tal Shnaiderman ; Yohad Tor > ; dmitry.kozl...@gmail.com; > harini.ramakrish...@microsoft.com; ocard...@microsoft.com; > pallavi.ka..

Re: [dpdk-dev] [PATCH v3 1/3] net: fix s_addr redefinition in Windows

2020-07-13 Thread Olivier Matz
Hi, On Wed, Jul 08, 2020 at 11:25:23AM +0300, Fady Bader wrote: > s_addr in Windows is defined in windows.h so its Is it windows.h, or is it winsock.h or winsock2.h instead? > undefined in order to be defined as part of rte_ether_hdr. > > Signed-off-by: Fady Bader > --- > lib/librte_net/rte_e

[dpdk-dev] [PATCH v3 1/3] net: fix s_addr redefinition in Windows

2020-07-08 Thread Fady Bader
s_addr in Windows is defined in windows.h so its undefined in order to be defined as part of rte_ether_hdr. Signed-off-by: Fady Bader --- lib/librte_net/rte_ether.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h index 0ae4e75b