Re: [dpdk-dev] [PATCH v3 1/4] eal: disable function versioning on Windows

2020-07-07 Thread Kinsella, Ray
On 05/07/2020 21:00, Thomas Monjalon wrote: > 05/07/2020 11:00, Thomas Monjalon: >> 05/07/2020 10:51, Fady Bader: >>> From: Thomas Monjalon 05/07/2020 09:00, Fady Bader: >> On 30/06/2020 11:49, Kinsella, Ray wrote: >>> On 22/06/2020 12:55, Fady Bader wrote: --- a/lib/librt

Re: [dpdk-dev] [PATCH v3 1/4] eal: disable function versioning on Windows

2020-07-05 Thread Thomas Monjalon
05/07/2020 11:00, Thomas Monjalon: > 05/07/2020 10:51, Fady Bader: > > From: Thomas Monjalon > > > 05/07/2020 09:00, Fady Bader: > > > > > On 30/06/2020 11:49, Kinsella, Ray wrote: > > > > > > On 22/06/2020 12:55, Fady Bader wrote: > > > > > >> --- a/lib/librte_eal/include/rte_function_versioning.

Re: [dpdk-dev] [PATCH v3 1/4] eal: disable function versioning on Windows

2020-07-05 Thread Thomas Monjalon
05/07/2020 10:51, Fady Bader: > From: Thomas Monjalon > > 05/07/2020 09:00, Fady Bader: > > > > On 30/06/2020 11:49, Kinsella, Ray wrote: > > > > > On 22/06/2020 12:55, Fady Bader wrote: > > > > >> --- a/lib/librte_eal/include/rte_function_versioning.h > > > > >> +++ b/lib/librte_eal/include/rte_f

Re: [dpdk-dev] [PATCH v3 1/4] eal: disable function versioning on Windows

2020-07-05 Thread Fady Bader
> -Original Message- > From: Thomas Monjalon > Sent: Sunday, July 5, 2020 11:38 AM > To: Kinsella, Ray ; Fady Bader > Cc: dev@dpdk.org; Tasnim Bashar ; Tal Shnaiderman > ; Yohad Tor ; > dmitry.kozl...@gmail.com; harini.ramakrish...@microsoft.com; > ocard...@microsoft.com; pallavi.ka...

Re: [dpdk-dev] [PATCH v3 1/4] eal: disable function versioning on Windows

2020-07-05 Thread Thomas Monjalon
05/07/2020 09:00, Fady Bader: > > On 30/06/2020 11:49, Kinsella, Ray wrote: > > > On 22/06/2020 12:55, Fady Bader wrote: > > >> --- a/lib/librte_eal/include/rte_function_versioning.h > > >> +++ b/lib/librte_eal/include/rte_function_versioning.h > > >> @@ -11,6 +11,10 @@ > > >> #error Use of functi

Re: [dpdk-dev] [PATCH v3 1/4] eal: disable function versioning on Windows

2020-07-05 Thread Fady Bader
> -Original Message- > From: Kinsella, Ray > Sent: Thursday, July 2, 2020 5:57 PM > To: Fady Bader ; dev@dpdk.org > Cc: Thomas Monjalon ; Tasnim Bashar > ; Tal Shnaiderman ; Yohad Tor > ; dmitry.kozl...@gmail.com; > harini.ramakrish...@microsoft.com; ocard...@microsoft.com; > pallavi.ka.

Re: [dpdk-dev] [PATCH v3 1/4] eal: disable function versioning on Windows

2020-07-02 Thread Kinsella, Ray
Fady, Any comments on the below? Ray K On 30/06/2020 11:49, Kinsella, Ray wrote: > > > On 22/06/2020 12:55, Fady Bader wrote: >> Function versioning is not needed on Windows, also the function versioning >> implementation is not supported by Windows. >> Function versioning was disabled on Wind

Re: [dpdk-dev] [PATCH v3 1/4] eal: disable function versioning on Windows

2020-07-02 Thread Fady Bader
pallavi.ka...@intel.com; ranjit.me...@intel.com; > olivier.m...@6wind.com; arybche...@solarflare.com; m...@ashroe.eu; > nhor...@tuxdriver.com > Subject: Re: [dpdk-dev] [PATCH v3 1/4] eal: disable function versioning on > Windows > > 22/06/2020 13:55, Fady Bader: > > Functi

Re: [dpdk-dev] [PATCH v3 1/4] eal: disable function versioning on Windows

2020-06-30 Thread Kinsella, Ray
On 22/06/2020 12:55, Fady Bader wrote: > Function versioning is not needed on Windows, also the function versioning > implementation is not supported by Windows. > Function versioning was disabled on Windows. > > Signed-off-by: Fady Bader > --- > lib/librte_eal/include/rte_function_versioning

Re: [dpdk-dev] [PATCH v3 1/4] eal: disable function versioning on Windows

2020-06-29 Thread Thomas Monjalon
22/06/2020 13:55, Fady Bader: > Function versioning is not needed on Windows, also the function versioning > implementation is not supported by Windows. I think it was said that "not needed" is not right. Let's just say that it is not supported for now. > Function versioning was disabled on Windo

[dpdk-dev] [PATCH v3 1/4] eal: disable function versioning on Windows

2020-06-22 Thread Fady Bader
Function versioning is not needed on Windows, also the function versioning implementation is not supported by Windows. Function versioning was disabled on Windows. Signed-off-by: Fady Bader --- lib/librte_eal/include/rte_function_versioning.h | 4 1 file changed, 4 insertions(+) diff --git