Re: [dpdk-dev] [PATCH v3 1/4] ethdev: simplify port state comparisons

2019-04-03 Thread Slava Ovsiienko
> -Original Message- > From: dev On Behalf Of Thomas Monjalon > Sent: Monday, April 1, 2019 5:27 > To: gaetan.ri...@6wind.com; Ferruh Yigit ; Andrew > Rybchenko > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v3 1/4] ethdev: simplify port state comparisons > >

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: simplify port state comparisons

2019-04-01 Thread Stephen Hemminger
On Mon, 01 Apr 2019 17:17:35 +0200 Thomas Monjalon wrote: > 01/04/2019 16:58, Stephen Hemminger: > > On Mon, 1 Apr 2019 04:26:57 +0200 > > Thomas Monjalon wrote: > > > > > diff --git a/lib/librte_ethdev/rte_ethdev.c > > > b/lib/librte_ethdev/rte_ethdev.c > > > index 10bdfb37e..33cffc498 100

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: simplify port state comparisons

2019-04-01 Thread Thomas Monjalon
01/04/2019 16:58, Stephen Hemminger: > On Mon, 1 Apr 2019 04:26:57 +0200 > Thomas Monjalon wrote: > > > diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c > > index 10bdfb37e..33cffc498 100644 > > --- a/lib/librte_ethdev/rte_ethdev.c > > +++ b/lib/librte_ethdev/rte_ethd

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: simplify port state comparisons

2019-04-01 Thread Stephen Hemminger
On Mon, 1 Apr 2019 04:26:57 +0200 Thomas Monjalon wrote: > diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c > index 10bdfb37e..33cffc498 100644 > --- a/lib/librte_ethdev/rte_ethdev.c > +++ b/lib/librte_ethdev/rte_ethdev.c > @@ -330,8 +330,7 @@ uint16_t > rte_eth_find

[dpdk-dev] [PATCH v3 1/4] ethdev: simplify port state comparisons

2019-03-31 Thread Thomas Monjalon
There are three states for an ethdev port. Checking that the port is unused looks simpler than checking it is neither attached nor removed. Signed-off-by: Thomas Monjalon Reviewed-by: Andrew Rybchenko --- lib/librte_ethdev/rte_ethdev.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-)