Re: [dpdk-dev] [PATCH v3 1/4] mbuf: detach mbuf with pinned external buffer

2020-01-15 Thread Slava Ovsiienko
> -Original Message- > From: Olivier Matz > Sent: Tuesday, January 14, 2020 17:27 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; Shahaf Shuler > ; step...@networkplumber.org > Subject: Re: [PATCH v3 1/4] mbuf: detach mbuf with pinned external buffer

Re: [dpdk-dev] [PATCH v3 1/4] mbuf: detach mbuf with pinned external buffer

2020-01-14 Thread Stephen Hemminger
On Tue, 14 Jan 2020 09:15:02 + Viacheslav Ovsiienko wrote: > +/** > + * Returns TRUE if given mbuf has an pinned external buffer, or FALSE > + * otherwise. The pinned external buffer is allocated at pool creation > + * time and should not be freed. > + * > + * External buffer is a user-provid

Re: [dpdk-dev] [PATCH v3 1/4] mbuf: detach mbuf with pinned external buffer

2020-01-14 Thread Olivier Matz
Hi Viacheslav, Please see some comments below. On Tue, Jan 14, 2020 at 09:15:02AM +, Viacheslav Ovsiienko wrote: > Update detach routine to check the mbuf pool type. > > Signed-off-by: Shahaf Shuler > Signed-off-by: Viacheslav Ovsiienko > --- > lib/librte_mbuf/rte_mbuf.h | 64 > +

[dpdk-dev] [PATCH v3 1/4] mbuf: detach mbuf with pinned external buffer

2020-01-14 Thread Viacheslav Ovsiienko
Update detach routine to check the mbuf pool type. Signed-off-by: Shahaf Shuler Signed-off-by: Viacheslav Ovsiienko --- lib/librte_mbuf/rte_mbuf.h | 64 +++--- 1 file changed, 60 insertions(+), 4 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib