[dpdk-dev] [PATCH v3 1/4] mbuf:add three TX offload flags and change three fields

2014-11-28 Thread Ananyev, Konstantin
> -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Friday, November 28, 2014 11:19 AM > To: Ananyev, Konstantin; Liu, Jijiang; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 1/4] mbuf:add three TX offload flags and > change th

[dpdk-dev] [PATCH v3 1/4] mbuf:add three TX offload flags and change three fields

2014-11-28 Thread Olivier MATZ
Hi Konstantin, On 11/28/2014 12:13 PM, Ananyev, Konstantin wrote: >>> For the upper layer, I think there would be no big difference, what ways we >>> will choose. >> >> I think the 2 informations are transversal, and that's why I would >> prefer 2 flags. Also, having 2 separate flags would also h

[dpdk-dev] [PATCH v3 1/4] mbuf:add three TX offload flags and change three fields

2014-11-28 Thread Olivier MATZ
Hi Konstantin, On 11/28/2014 11:40 AM, Ananyev, Konstantin wrote: > > Well, I still prefer them to be mutually exclusive. > Even better, if we can squeeze these 3 flags into 2 bits. > Would save us 2 bits, plus might be handy, as in the PMD you can do: > > switch (ol_flags & TX_L3_MASK) { >

[dpdk-dev] [PATCH v3 1/4] mbuf:add three TX offload flags and change three fields

2014-11-28 Thread Ananyev, Konstantin
> -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Friday, November 28, 2014 11:00 AM > To: Ananyev, Konstantin; Liu, Jijiang; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 1/4] mbuf:add three TX offload flags and > change th

[dpdk-dev] [PATCH v3 1/4] mbuf:add three TX offload flags and change three fields

2014-11-28 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Liu, Jijiang > Sent: Friday, November 28, 2014 10:33 AM > To: Olivier MATZ; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 1/4] mbuf:add three TX offload flags and > change three fiel

[dpdk-dev] [PATCH v3 1/4] mbuf:add three TX offload flags and change three fields

2014-11-28 Thread Olivier MATZ
Hi Jijiang, On 11/27/2014 06:03 PM, Jijiang Liu wrote: > /** Tell the NIC it's an IPv4 packet. Required for L4 checksum offload or > TSO. */ > #define PKT_TX_IPV4 PKT_RX_IPV4_HDR > > /** Tell the NIC it's an IPv6 packet. Required for L4 checksum offload or > TSO. */ > #define PKT_

[dpdk-dev] [PATCH v3 1/4] mbuf:add three TX offload flags and change three fields

2014-11-28 Thread Liu, Jijiang
Hi Olivier, > -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Friday, November 28, 2014 5:37 PM > To: Liu, Jijiang; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 1/4] mbuf:add three TX offload flags and > change three fiel

[dpdk-dev] [PATCH v3 1/4] mbuf:add three TX offload flags and change three fields

2014-11-28 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Olivier MATZ > Sent: Friday, November 28, 2014 9:37 AM > To: Liu, Jijiang; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 1/4] mbuf:add three TX offload flags and > change three fiel

[dpdk-dev] [PATCH v3 1/4] mbuf:add three TX offload flags and change three fields

2014-11-28 Thread Jijiang Liu
In place of removing the PKT_TX_VXLAN_CKSUM, we introduce 3 new flags: PKT_TX_OUTER_IP_CKSUM, PKT_TX_OUTER_IPV6 and PKT_TX_UDP_TUNNEL_PKT, and a new field: l4_tun_len. Replace the inner_l2_len and the inner_l3_len field with the outer_l2_len and outer_l3_len field. PKT_TX_OUTER_IP_CKSUM: is not