Re: [dpdk-dev] [PATCH v3 1/5] net/fm10k: add basic functions for switch management

Hi Xiao, Please check the source file. It not looks align in patch file because the patch add "+" for each new line. Best regards, Xiaojun -Original Message- From: Wang, Xiao W [mailto:xiao.w.w...@intel.com] Sent: Thursday, April 02, 2020 4:42 PM To: Xiaojun Liu; Zhang, Qi Z; Kwan, Nga

Re: [dpdk-dev] [PATCH v3 1/5] net/fm10k: add basic functions for switch management

Hi Xiaojun, Just comments on the alignment issue, things like below looks not nice. If you are using vim, I recommend " set tabstop=8 " setting. +#define FM10K_SW_BIST_CTRL_BIST_RUN_PCIE(p_) (1ULL << (p_)) +#define FM10K_SW_BIST_CTRL_BIST_RUN_EPL(1ULL << 9) +#define FM10K_SW_BI

[dpdk-dev] [PATCH v3 1/5] net/fm10k: add basic functions for switch management

Add I2C to control the inside LED and PHY. All the operations of I2C are using fm10k I2C register. Add SBUS to communicate with spico(micro code in serdes) by using fm10k SBUS register. This is like I2C operations. Add registers defination, which include all the registers will be used in the driver