Re: [dpdk-dev] [PATCH v3 2/2] cmdline: make struct rdline opaque

2021-10-05 Thread Olivier Matz
On Tue, Oct 05, 2021 at 12:03:01PM +0300, Dmitry Kozlyuk wrote: > Hi Olivier, > > Thanks for the review, please see below. > > 2021-10-05 10:27 (UTC+0200), Olivier Matz: > > [...] > > > diff --git a/lib/cmdline/cmdline_cirbuf.c b/lib/cmdline/cmdline_cirbuf.c > > > index 829a8af563..cbb76a7016 100

Re: [dpdk-dev] [PATCH v3 2/2] cmdline: make struct rdline opaque

2021-10-05 Thread Dmitry Kozlyuk
Hi Olivier, Thanks for the review, please see below. 2021-10-05 10:27 (UTC+0200), Olivier Matz: > [...] > > diff --git a/lib/cmdline/cmdline_cirbuf.c b/lib/cmdline/cmdline_cirbuf.c > > index 829a8af563..cbb76a7016 100644 > > --- a/lib/cmdline/cmdline_cirbuf.c > > +++ b/lib/cmdline/cmdline_cirbuf.

Re: [dpdk-dev] [PATCH v3 2/2] cmdline: make struct rdline opaque

2021-10-05 Thread Olivier Matz
Hi Dmitry, Few comments below. On Tue, Oct 05, 2021 at 03:55:16AM +0300, Dmitry Kozlyuk wrote: > Hide struct rdline definition and some RDLINE_* constants in order > to be able to change internal buffer sizes transparently to the user. > Add new functions: > > * rdline_create(): allocate and ini

[dpdk-dev] [PATCH v3 2/2] cmdline: make struct rdline opaque

2021-10-04 Thread Dmitry Kozlyuk
Hide struct rdline definition and some RDLINE_* constants in order to be able to change internal buffer sizes transparently to the user. Add new functions: * rdline_create(): allocate and initialize struct rdline. This function replaces rdline_init() and takes an extra parameter: opaque user d