Re: [dpdk-dev] [PATCH v3 2/2] ethdev: device configuration enhancement

2018-11-13 Thread Lu, Wenzhuo
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, November 13, 2018 5:41 PM > To: Lu, Wenzhuo ; Andrew Rybchenko > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 2/2] ethdev: device configuration > enhancement > > On 11/13/2018 12:46 AM

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: device configuration enhancement

2018-11-13 Thread Ferruh Yigit
On 11/13/2018 12:46 AM, Lu, Wenzhuo wrote: > Hi Ferruh, > > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Saturday, November 10, 2018 5:10 AM >> To: Andrew Rybchenko ; Lu, Wenzhuo >> ; dev@dpdk.org >> Subject: Re: [dpdk-dev

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: device configuration enhancement

2018-11-12 Thread Lu, Wenzhuo
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Saturday, November 10, 2018 5:10 AM > To: Andrew Rybchenko ; Lu, Wenzhuo > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 2/2] ethdev: device configuration > enhancement > > On 11/8/2018 6:25

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: device configuration enhancement

2018-11-09 Thread Ferruh Yigit
On 11/8/2018 6:25 AM, Andrew Rybchenko wrote: > On 11/8/18 5:09 AM, Wenzhuo Lu wrote: >> The new configuration is stored during the process. >> But the process may fail. We better rolling the >> configuration back as the new one doesn't take effect. >> >> Signed-off-by: Wenzhuo Lu > > I would say

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: device configuration enhancement

2018-11-07 Thread Andrew Rybchenko
On 11/8/18 5:09 AM, Wenzhuo Lu wrote: The new configuration is stored during the process. But the process may fail. We better rolling the configuration back as the new one doesn't take effect. Signed-off-by: Wenzhuo Lu I would say that the order is wrong. We should fix this bug first and the

[dpdk-dev] [PATCH v3 2/2] ethdev: device configuration enhancement

2018-11-07 Thread Wenzhuo Lu
The new configuration is stored during the process. But the process may fail. We better rolling the configuration back as the new one doesn't take effect. Signed-off-by: Wenzhuo Lu --- lib/librte_ethdev/rte_ethdev.c | 59 ++ 1 file changed, 43 insertions(+