; Sent: Tuesday, November 10, 2015 4:08 PM
> > > To: Richardson, Bruce
> > > Cc: Stephen Hemminger ; Thomas Monjalon
> > > ; dev at dpdk.org
> > > Subject: Re: [dpdk-dev] [PATCH v3 2/4] ethdev: move error checking macros
> > > to header
> > >
>
emminger ; Thomas Monjalon
> > ; dev at dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH v3 2/4] ethdev: move error checking macros
> > to header
> >
> > On Mon, Nov 09, 2015 at 02:02:28PM +, Richardson, Bruce wrote:
> > [...]
> > > > From: Adrien Maz
On Mon, Nov 09, 2015 at 02:02:28PM +, Richardson, Bruce wrote:
[...]
> > From: Adrien Mazarguil [mailto:adrien.mazarguil at 6wind.com]
[...]
> > Untested but I guess modifying that function accordingly would look like:
> >
> > static inline void
> > rte_pmd_debug_trace(const char
> -Original Message-
> From: Adrien Mazarguil [mailto:adrien.mazarguil at 6wind.com]
> Sent: Tuesday, November 10, 2015 4:08 PM
> To: Richardson, Bruce
> Cc: Stephen Hemminger ; Thomas Monjalon
> ; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 2/4] ethdev
t; ; dev at dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v3 2/4] ethdev: move error checking macros
>> to header
>>
>> On Fri, Nov 06, 2015 at 05:22:27PM +, Bruce Richardson wrote:
>>> On Fri, Nov 06, 2015 at 05:10:07PM +, Bruce Richardson wrote:
>>>>
On Mon, Nov 09, 2015 at 02:39:05PM +0100, Adrien Mazarguil wrote:
> On Fri, Nov 06, 2015 at 05:22:27PM +, Bruce Richardson wrote:
> > On Fri, Nov 06, 2015 at 05:10:07PM +, Bruce Richardson wrote:
> > > On Thu, Nov 05, 2015 at 04:09:18PM +0100, Adrien Mazarguil wrote:
> > > >
> > > > I
On Fri, Nov 06, 2015 at 05:22:27PM +, Bruce Richardson wrote:
> On Fri, Nov 06, 2015 at 05:10:07PM +, Bruce Richardson wrote:
> > On Thu, Nov 05, 2015 at 04:09:18PM +0100, Adrien Mazarguil wrote:
> > >
> > > I won't argue against this as it's obviously more complex than the
> > >
> -Original Message-
> From: Adrien Mazarguil [mailto:adrien.mazarguil at 6wind.com]
> Sent: Monday, November 9, 2015 1:39 PM
> To: Richardson, Bruce
> Cc: Stephen Hemminger ; Thomas Monjalon
> ; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 2/4] ethdev: move
On Fri, Nov 06, 2015 at 05:10:07PM +, Bruce Richardson wrote:
> On Thu, Nov 05, 2015 at 04:09:18PM +0100, Adrien Mazarguil wrote:
> >
> > I won't argue against this as it's obviously more complex than the original
> > method, however note that users of the RTE_PMD_DEBUG_TRACE() macro do not
>
On Thu, Nov 05, 2015 at 04:09:18PM +0100, Adrien Mazarguil wrote:
>
> I won't argue against this as it's obviously more complex than the original
> method, however note that users of the RTE_PMD_DEBUG_TRACE() macro do not
> have to modify their code. They shouldn't care about the implementation.
> -Original Message-
> From: Adrien Mazarguil [mailto:adrien.mazarguil at 6wind.com]
>
> On Fri, Nov 06, 2015 at 02:39:31PM +, Richardson, Bruce wrote:
> [...]
> > > > Hi Adrien,
> > > >
> > > > I'm trying to dig into this a bit more now, and try out using a
> > > > static inline
gt;
> > - Forwarded message from Bruce Richardson
> > -
> >
> > Date: Fri, 6 Nov 2015 11:49:05 +
> > From: Bruce Richardson
> > To: Stephen Hemminger , Thomas Monjalon
> > , dev at dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH v3 2/4
on
> To: Stephen Hemminger , Thomas Monjalon
> , dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 2/4] ethdev: move error checking macros to
> header
> User-Agent: Mutt/1.5.23 (2014-03-12)
>
> On Thu, Nov 05, 2015 at 04:09:18PM +0100, Adrien Mazarguil wrote:
> > Bruce
TCH v3 2/4] ethdev: move error checking macros to
header
User-Agent: Mutt/1.5.23 (2014-03-12)
On Thu, Nov 05, 2015 at 04:09:18PM +0100, Adrien Mazarguil wrote:
> Bruce is asking for a consensus about -pedantic, whether we want to do the
> extra effort to support it in DPDK. Since I l
On Thu, Nov 05, 2015 at 04:09:18PM +0100, Adrien Mazarguil wrote:
> Bruce is asking for a consensus about -pedantic, whether we want to do the
> extra effort to support it in DPDK. Since I like checking for -pedantic
> errors, it's enabled for mlx4 and mlx5 when compiling these drivers in
>
On Wed, Nov 04, 2015 at 10:39:57AM -0800, Stephen Hemminger wrote:
> On Wed, 4 Nov 2015 11:24:18 +0100
> Adrien Mazarguil wrote:
>
> > On Wed, Nov 04, 2015 at 02:19:36AM +0100, Thomas Monjalon wrote:
> > > 2015-11-03 12:00, Bruce Richardson:
> > > > Move the function ptr and port id checking
On Thu, Nov 05, 2015 at 04:09:18PM +0100, Adrien Mazarguil wrote:
> On Wed, Nov 04, 2015 at 10:39:57AM -0800, Stephen Hemminger wrote:
> > On Wed, 4 Nov 2015 11:24:18 +0100
> > Adrien Mazarguil wrote:
> >
> > > On Wed, Nov 04, 2015 at 02:19:36AM +0100, Thomas Monjalon wrote:
> > > > 2015-11-03
On Wed, Nov 04, 2015 at 02:10:50PM +, Bruce Richardson wrote:
> On Wed, Nov 04, 2015 at 11:24:18AM +0100, Adrien Mazarguil wrote:
> > On Wed, Nov 04, 2015 at 02:19:36AM +0100, Thomas Monjalon wrote:
> > > 2015-11-03 12:00, Bruce Richardson:
> > > > Move the function ptr and port id checking
On Wed, Nov 04, 2015 at 11:24:18AM +0100, Adrien Mazarguil wrote:
> On Wed, Nov 04, 2015 at 02:19:36AM +0100, Thomas Monjalon wrote:
> > 2015-11-03 12:00, Bruce Richardson:
> > > Move the function ptr and port id checking macros to the header file, so
> > > that they can be used in the static
On Wed, Nov 04, 2015 at 02:19:36AM +0100, Thomas Monjalon wrote:
> 2015-11-03 12:00, Bruce Richardson:
> > Move the function ptr and port id checking macros to the header file, so
> > that they can be used in the static inline functions there. In doxygen
> > comments, mark them as for internal use
On Wed, 4 Nov 2015 11:24:18 +0100
Adrien Mazarguil wrote:
> On Wed, Nov 04, 2015 at 02:19:36AM +0100, Thomas Monjalon wrote:
> > 2015-11-03 12:00, Bruce Richardson:
> > > Move the function ptr and port id checking macros to the header file, so
> > > that they can be used in the static inline
2015-11-03 12:00, Bruce Richardson:
> Move the function ptr and port id checking macros to the header file, so
> that they can be used in the static inline functions there. In doxygen
> comments, mark them as for internal use only.
[...]
> +/**
> + * @internal
> + * Macro to print a message if in
Move the function ptr and port id checking macros to the header file, so
that they can be used in the static inline functions there. In doxygen
comments, mark them as for internal use only.
Signed-off-by: Bruce Richardson
---
lib/librte_ether/rte_ethdev.c | 38 --
23 matches
Mail list logo
