Re: [dpdk-dev] [PATCH v3 2/4] kni: fix kni fifo synchronization

2018-10-10 Thread Ferruh Yigit
m; Gavin Hu (Arm >> Technology China) ; Honnappa Nagarahalli >> ; Ola Liljedahl ; >> ferruh.yi...@intel.com >> Subject: RE: [dpdk-dev] [PATCH v3 2/4] kni: fix kni fifo synchronization >> >> Hi Hemminger, >> >>> -Original Message- >>

Re: [dpdk-dev] [PATCH v3 2/4] kni: fix kni fifo synchronization

2018-10-10 Thread Gavin Hu (Arm Technology China)
; ferruh.yi...@intel.com > Subject: RE: [dpdk-dev] [PATCH v3 2/4] kni: fix kni fifo synchronization > > Hi Hemminger, > > > -Original Message- > > From: Stephen Hemminger > > Sent: Tuesday, October 9, 2018 5:53 AM > > To: Phil Yang (Arm Technology China) &g

Re: [dpdk-dev] [PATCH v3 2/4] kni: fix kni fifo synchronization

2018-10-10 Thread Phil Yang (Arm Technology China)
ljedahl ; > ferruh.yi...@intel.com > Subject: Re: [dpdk-dev] [PATCH v3 2/4] kni: fix kni fifo synchronization > > On Mon, 8 Oct 2018 17:11:44 +0800 > Phil Yang wrote: > > > diff --git a/lib/librte_kni/rte_kni_fifo.h > > b/lib/librte_kni/rte_kni_fifo.h index ac26a8c..70a

Re: [dpdk-dev] [PATCH v3 2/4] kni: fix kni fifo synchronization

2018-10-08 Thread Stephen Hemminger
On Mon, 8 Oct 2018 17:11:44 +0800 Phil Yang wrote: > diff --git a/lib/librte_kni/rte_kni_fifo.h b/lib/librte_kni/rte_kni_fifo.h > index ac26a8c..70ac14e 100644 > --- a/lib/librte_kni/rte_kni_fifo.h > +++ b/lib/librte_kni/rte_kni_fifo.h > @@ -28,8 +28,9 @@ kni_fifo_put(struct rte_kni_fifo *fifo,

[dpdk-dev] [PATCH v3 2/4] kni: fix kni fifo synchronization

2018-10-08 Thread Phil Yang
With existing code in kni_fifo_put, rx_q values are not being updated before updating fifo_write. While reading rx_q in kni_net_rx_normal, This is causing the sync issue on other core. The same situation happens in kni_fifo_get as well. So syncing the values by adding memory barriers to make sure