Re: [dpdk-dev] [PATCH v3 2/7] eal/interrupts: implement get set APIs

2021-10-18 Thread Stephen Hemminger
On Tue, 19 Oct 2021 01:07:02 +0530 Harman Kalra wrote: > + /* Detect if DPDK malloc APIs are ready to be used. */ > + mem_allocator = rte_malloc_is_ready(); > + if (mem_allocator) > + intr_handle = rte_zmalloc(NULL, sizeof(struct rte_intr_handle), > +

Re: [dpdk-dev] [PATCH v3 2/7] eal/interrupts: implement get set APIs

2021-10-18 Thread Dmitry Kozlyuk
2021-10-19 01:07 (UTC+0530), Harman Kalra: [...] > +struct rte_intr_handle *rte_intr_instance_alloc(void) > +{ > + struct rte_intr_handle *intr_handle; > + bool mem_allocator; This name is not very descriptive; what would "mem_allocator is false" mean? How about "is_rte_memory"? > + > +

[dpdk-dev] [PATCH v3 2/7] eal/interrupts: implement get set APIs

2021-10-18 Thread Harman Kalra
Prototype/Implement get set APIs for interrupt handle fields. User won't be able to access any of the interrupt handle fields directly while should use these get/set APIs to access/manipulate them. Internal interrupt header i.e. rte_eal_interrupt.h is rearranged, as APIs defined are moved to rte_i