[dpdk-dev] [PATCH v3 3/4] bonding: take queue spinlock in rx/tx burst functions

2016-09-09 Thread Ferruh Yigit
Hi Bernard, This is an old patch, sorry for commenting after this long. On 6/12/2016 6:11 PM, Bernard Iremonger wrote: > Use rte_spinlock_trylock() in the rx/tx burst functions to > take the queue spinlock. > > Signed-off-by: Bernard Iremonger > Acked-by: Konstantin Ananyev > --- ... > stat

[dpdk-dev] [PATCH v3 3/4] bonding: take queue spinlock in rx/tx burst functions

2016-06-16 Thread Bruce Richardson
On Mon, Jun 13, 2016 at 01:28:08PM +0100, Iremonger, Bernard wrote: > Hi Bruce, > > > > > Subject: Re: [dpdk-dev] [PATCH v3 3/4] bonding: take queue spinlock in rx/tx > > burst functions > > > > On Sun, Jun 12, 2016 at 06:11:28PM +0100, Bernard Iremonger w

[dpdk-dev] [PATCH v3 3/4] bonding: take queue spinlock in rx/tx burst functions

2016-06-16 Thread Thomas Monjalon
2016-06-16 15:32, Bruce Richardson: > On Mon, Jun 13, 2016 at 01:28:08PM +0100, Iremonger, Bernard wrote: > > > Why does this particular PMD need spinlocks when doing RX and TX, while > > > other device types do not? How is adding/removing devices from a bonded > > > device different to other contr

[dpdk-dev] [PATCH v3 3/4] bonding: take queue spinlock in rx/tx burst functions

2016-06-16 Thread Iremonger, Bernard
Hi Thomas, > 2016-06-16 15:32, Bruce Richardson: > > On Mon, Jun 13, 2016 at 01:28:08PM +0100, Iremonger, Bernard wrote: > > > > Why does this particular PMD need spinlocks when doing RX and TX, > > > > while other device types do not? How is adding/removing devices > > > > from a bonded device di

[dpdk-dev] [PATCH v3 3/4] bonding: take queue spinlock in rx/tx burst functions

2016-06-16 Thread Thomas Monjalon
2016-06-16 16:41, Iremonger, Bernard: > Hi Thomas, > > > 2016-06-16 15:32, Bruce Richardson: > > > On Mon, Jun 13, 2016 at 01:28:08PM +0100, Iremonger, Bernard wrote: > > > > > Why does this particular PMD need spinlocks when doing RX and TX, > > > > > while other device types do not? How is addin

[dpdk-dev] [PATCH v3 3/4] bonding: take queue spinlock in rx/tx burst functions

2016-06-12 Thread Bernard Iremonger
Use rte_spinlock_trylock() in the rx/tx burst functions to take the queue spinlock. Signed-off-by: Bernard Iremonger Acked-by: Konstantin Ananyev --- drivers/net/bonding/rte_eth_bond_pmd.c | 116 - 1 file changed, 84 insertions(+), 32 deletions(-) diff --git a/d

[dpdk-dev] [PATCH v3 3/4] bonding: take queue spinlock in rx/tx burst functions

2016-06-13 Thread Bruce Richardson
On Sun, Jun 12, 2016 at 06:11:28PM +0100, Bernard Iremonger wrote: > Use rte_spinlock_trylock() in the rx/tx burst functions to > take the queue spinlock. > > Signed-off-by: Bernard Iremonger > Acked-by: Konstantin Ananyev > --- Why does this particular PMD need spinlocks when doing RX and TX,

[dpdk-dev] [PATCH v3 3/4] bonding: take queue spinlock in rx/tx burst functions

2016-06-13 Thread Iremonger, Bernard
Hi Bruce, > Subject: Re: [dpdk-dev] [PATCH v3 3/4] bonding: take queue spinlock in rx/tx > burst functions > > On Sun, Jun 12, 2016 at 06:11:28PM +0100, Bernard Iremonger wrote: > > Use rte_spinlock_trylock() in the rx/tx burst functions to take the > > queue spinloc

Re: [dpdk-dev] [PATCH v3 3/4] bonding: take queue spinlock in rx/tx burst functions

2017-02-15 Thread Ferruh Yigit
On 6/16/2016 7:38 PM, thomas.monjalon at 6wind.com (Thomas Monjalon) wrote: > 2016-06-16 16:41, Iremonger, Bernard: >> Hi Thomas, >> >>> 2016-06-16 15:32, Bruce Richardson: On Mon, Jun 13, 2016 at 01:28:08PM +0100, Iremonger, Bernard wrote: >> Why does this particular PMD need spinlocks w

Re: [dpdk-dev] [PATCH v3 3/4] bonding: take queue spinlock in rx/tx burst functions

2017-02-16 Thread Bruce Richardson
On Wed, Feb 15, 2017 at 06:01:45PM +, Ferruh Yigit wrote: > On 6/16/2016 7:38 PM, thomas.monjalon at 6wind.com (Thomas Monjalon) wrote: > > 2016-06-16 16:41, Iremonger, Bernard: > >> Hi Thomas, > >> > >>> 2016-06-16 15:32, Bruce Richardson: > On Mon, Jun 13, 2016 at 01:28:08PM +0100, Irem

Re: [dpdk-dev] [PATCH v3 3/4] bonding: take queue spinlock in rx/tx burst functions

2017-02-16 Thread Iremonger, Bernard
Hi Ferruh, > -Original Message- > From: Richardson, Bruce > Sent: Thursday, February 16, 2017 9:14 AM > To: Yigit, Ferruh > Cc: Thomas Monjalon ; Iremonger, Bernard > ; Ananyev, Konstantin > ; Doherty, Declan > ; DPDK > Subject: Re: [dpdk-dev] [PATCH v3 3/4] b

Re: [dpdk-dev] [PATCH v3 3/4] bonding: take queue spinlock in rx/tx burst functions

2017-02-20 Thread Ferruh Yigit
Konstantin >> ; Doherty, Declan >> ; DPDK >> Subject: Re: [dpdk-dev] [PATCH v3 3/4] bonding: take queue spinlock in rx/tx >> burst functions >> >> On Wed, Feb 15, 2017 at 06:01:45PM +, Ferruh Yigit wrote: >>> On 6/16/2016 7:38 PM, thomas.monjalon at 6wind.com