Re: [dpdk-dev] [PATCH v3 4/7] build: MinGW-w64 support for Meson

2020-02-18 Thread Bruce Richardson
On Tue, Feb 18, 2020 at 03:26:47PM +0100, Thomas Monjalon wrote: > 18/02/2020 01:02, Dmitry Kozlyuk: > > --- a/config/meson.build > > +++ b/config/meson.build > > +# MS linker requires special treatment. > > +# FIXME: use cc.get_linker_id() with Meson >= 0.54 > > +is_ms_linker = is_windows and (cc.

Re: [dpdk-dev] [PATCH v3 4/7] build: MinGW-w64 support for Meson

2020-02-18 Thread Thomas Monjalon
18/02/2020 01:02, Dmitry Kozlyuk: > --- a/config/meson.build > +++ b/config/meson.build > +# MS linker requires special treatment. > +# FIXME: use cc.get_linker_id() with Meson >= 0.54 > +is_ms_linker = is_windows and (cc.get_id() == 'clang') Please could you replace this FIXME with an actual fix

[dpdk-dev] [PATCH v3 4/7] build: MinGW-w64 support for Meson

2020-02-17 Thread Dmitry Kozlyuk
MinGW-w64 linker does not mimic MS linker options, so the build system must differentiate between linkers on Windows. Use GNU linker options with GCC and MS linker options with Clang. MinGW-w64 by default uses MSVCRT stdio, which does not comply to ANSI, most notably its formatting and string hand