Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-25 Thread Ananyev, Konstantin
Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port > ownership > > 25/01/2018 12:15, Ananyev, Konstantin: > > Hi everyone, > > > > > > > > 25/01/2018 10:36, Matan Azrad: > > > > Gaetan, Konstantin, Thomas > > > > > >

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-25 Thread Thomas Monjalon
25/01/2018 12:15, Ananyev, Konstantin: > Hi everyone, > > > > > 25/01/2018 10:36, Matan Azrad: > > > Gaetan, Konstantin, Thomas > > > > > > Any response to my suggestion below? > > > > > > From: Matan Azrad > > > > Suggestion: > > > > > > > > 2 system owners. > > > > APP_OWNER - 1. > > > > NO_OWN

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-25 Thread Thomas Monjalon
25/01/2018 12:09, Ananyev, Konstantin: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 24/01/2018 19:30, Ananyev, Konstantin: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > 23/01/2018 22:18, Ananyev, Konstantin: > > > > > > > > > > > > 23/01/2018 16:18, Ananyev, Konstanti

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-25 Thread Ananyev, Konstantin
Hi everyone, > > 25/01/2018 10:36, Matan Azrad: > > Gaetan, Konstantin, Thomas > > > > Any response to my suggestion below? > > > > From: Matan Azrad > > > Suggestion: > > > > > > 2 system owners. > > > APP_OWNER - 1. > > > NO_OWNER - 0. > > > > > > And allowing for more owners as now. > > > > >

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-25 Thread Ananyev, Konstantin
Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port > ownership > > 24/01/2018 19:30, Ananyev, Konstantin: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > 23/01/2018 22:18, Ananyev, Konstantin: > > > > > > > > > &

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-25 Thread Thomas Monjalon
24/01/2018 19:30, Ananyev, Konstantin: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 23/01/2018 22:18, Ananyev, Konstantin: > > > > > > > > 23/01/2018 16:18, Ananyev, Konstantin: > > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, > > > > > Konstantin > > > > > > Fro

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-25 Thread Thomas Monjalon
25/01/2018 10:36, Matan Azrad: > Gaetan, Konstantin, Thomas > > Any response to my suggestion below? > > From: Matan Azrad > > Suggestion: > > > > 2 system owners. > > APP_OWNER - 1. > > NO_OWNER - 0. > > > > And allowing for more owners as now. > > > > 1. Every port creation will set the owne

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-25 Thread Matan Azrad
Gaetan, Konstantin, Thomas Any response to my suggestion below? From: Matan Azrad > Hi > > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > > > > > > > Look, > > > > > > > > Testpmd initiates some of its internal databases depends > > > > > > > > on specific port iteration, In some time som

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-24 Thread Ananyev, Konstantin
Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port > ownership > > 23/01/2018 22:18, Ananyev, Konstantin: > > > > > > 23/01/2018 16:18, Ananyev, Konstantin: > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin > >

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-24 Thread Thomas Monjalon
23/01/2018 22:18, Ananyev, Konstantin: > > > > 23/01/2018 16:18, Ananyev, Konstantin: > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > > 23/01/2018 14:34, Ananyev, Konstantin: > > > > > > If that' s th

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-23 Thread Ananyev, Konstantin
> > 23/01/2018 16:18, Ananyev, Konstantin: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > 23/01/2018 14:34, Ananyev, Konstantin: > > > > > If that' s the use case, then I think you need to set device >

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-23 Thread Thomas Monjalon
23/01/2018 16:18, Ananyev, Konstantin: > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > 23/01/2018 14:34, Ananyev, Konstantin: > > > > If that' s the use case, then I think you need to set device ownership > > >

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-23 Thread Ananyev, Konstantin
t; > Subject: Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port > ownership > > > > > -Original Message- > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Tuesday, January 23, 2018 2:19 PM > > To: Ananyev, Konstantin &

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-23 Thread Ananyev, Konstantin
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, January 23, 2018 2:19 PM > To: Ananyev, Konstantin > Cc: Matan Azrad ; Gaëtan Rivet ; > Wu, Jingjing ; > dev@dpdk.org; Neil Horman ; Richardson, Bruce > > Subject: Re: [PATCH v3 7/7] app/testpmd

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-23 Thread Matan Azrad
Hi Konstantin Please move the second thread, I'm feeling you and Gaetan have the same questions. From: Ananyev, Konstantin, Tuesday, January 23, 2018 3:35 PM > Hi Matan, > > > > > > > Hi Konstantin > > From: Ananyev, Konstantin, Monday, January 22, 2018 10:49 PM > > > Hi Matan, > > > > > > > --

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-23 Thread Matan Azrad
Hi From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > > > > > > Look, > > > > > > > Testpmd initiates some of its internal databases depends on > > > > > > > specific port iteration, In some time someone may take > > > > > > > ownership of Testpmd ports and testpmd will continue to touch > them

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-23 Thread Thomas Monjalon
23/01/2018 14:34, Ananyev, Konstantin: > If that' s the use case, then I think you need to set device ownership at > creation time - > inside dev_allocate(). > Again that would avoid such racing conditions inside testpmd. The devices must be allocated at a low level layer. When a new device appea

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-23 Thread Ananyev, Konstantin
Hi Matan, > > > Hi Konstantin > From: Ananyev, Konstantin, Monday, January 22, 2018 10:49 PM > > Hi Matan, > > > > > -Original Message- > > > From: Matan Azrad [mailto:ma...@mellanox.com] > > > Sent: Monday, January 22, 2018 1:23 PM > > > To: Ananyev, Konstantin ; Gaëtan Rivet > > > > >

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-23 Thread Gaëtan Rivet
Hi all, On Tue, Jan 23, 2018 at 08:54:27AM +, Matan Azrad wrote: > > > > > > > > > > Subject: [PATCH v3 7/7] app/testpmd: adjust ethdev port > > > > > > > > > > ownership > > > > > > > > > > > > > > > > > > > > Testpmd should not use ethdev ports which are managed by > > > > > > > > > > oth

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-23 Thread Matan Azrad
Hi Konstantin From: Ananyev, Konstantin, Monday, January 22, 2018 10:49 PM > Hi Matan, > > > -Original Message- > > From: Matan Azrad [mailto:ma...@mellanox.com] > > Sent: Monday, January 22, 2018 1:23 PM > > To: Ananyev, Konstantin ; Gaëtan Rivet > > > > Cc: Thomas Monjalon ; Wu, Jingji

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-22 Thread Ananyev, Konstantin
Hi Matan, > -Original Message- > From: Matan Azrad [mailto:ma...@mellanox.com] > Sent: Monday, January 22, 2018 1:23 PM > To: Ananyev, Konstantin ; Gaëtan Rivet > > Cc: Thomas Monjalon ; Wu, Jingjing > ; dev@dpdk.org; Neil Horman > ; Richardson, Bruce > Subject: RE: [PATCH v3 7/7] app/

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-22 Thread Matan Azrad
Hi From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] > Hi lads, > > > > > Hi Matan, > > > > On Fri, Jan 19, 2018 at 01:35:10PM +, Matan Azrad wrote: > > > Hi Konstantin > > > > > > From: Ananyev, Konstantin, Friday, January 19, 2018 3:09 PM > > > > > -Original Message-

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-22 Thread Ananyev, Konstantin
Hi lads, > > Hi Matan, > > On Fri, Jan 19, 2018 at 01:35:10PM +, Matan Azrad wrote: > > Hi Konstantin > > > > From: Ananyev, Konstantin, Friday, January 19, 2018 3:09 PM > > > > -Original Message- > > > > From: Matan Azrad [mailto:ma...@mellanox.com] > > > > Sent: Friday, January 19,

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-22 Thread Matan Azrad
Hi Gaetan From: Gaëtan Rivet, Monday, January 22, 2018 12:17 PM > Hi Matan, > > On Sat, Jan 20, 2018 at 06:14:13PM +, Matan Azrad wrote: > > > > > > > > > > > @@ -1394,7 +1394,7 @@ struct cmd_config_speed_all { > > > > > > > > &link_speed) < 0) > > > > > > > >

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-22 Thread Gaëtan Rivet
Hi Matan, On Sat, Jan 20, 2018 at 06:14:13PM +, Matan Azrad wrote: > > > > > > > @@ -1394,7 +1394,7 @@ struct cmd_config_speed_all { > > > > > > > &link_speed) < 0) > > > > > > > return; > > > > > > > > > > > > > > - RTE_ETH_FOREACH_DEV(pid) { > > > > > > > + RTE

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-20 Thread Matan Azrad
Hi Gaetan From: Gaëtan Rivet, Friday, January 19, 2018 5:00 PM > Hi Matan, > > On Fri, Jan 19, 2018 at 01:35:10PM +, Matan Azrad wrote: > > Hi Konstantin > > > > From: Ananyev, Konstantin, Friday, January 19, 2018 3:09 PM > > > > -Original Message- > > > > From: Matan Azrad [mailto:ma

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-19 Thread Gaëtan Rivet
Hi Matan, On Fri, Jan 19, 2018 at 01:35:10PM +, Matan Azrad wrote: > Hi Konstantin > > From: Ananyev, Konstantin, Friday, January 19, 2018 3:09 PM > > > -Original Message- > > > From: Matan Azrad [mailto:ma...@mellanox.com] > > > Sent: Friday, January 19, 2018 12:52 PM > > > To: Anany

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-19 Thread Matan Azrad
Hi Konstantin From: Ananyev, Konstantin, Friday, January 19, 2018 3:09 PM > > -Original Message- > > From: Matan Azrad [mailto:ma...@mellanox.com] > > Sent: Friday, January 19, 2018 12:52 PM > > To: Ananyev, Konstantin ; Thomas > > Monjalon ; Gaetan Rivet > ; > > Wu, Jingjing > > Cc: dev@

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-19 Thread Ananyev, Konstantin
> -Original Message- > From: Matan Azrad [mailto:ma...@mellanox.com] > Sent: Friday, January 19, 2018 12:52 PM > To: Ananyev, Konstantin ; Thomas Monjalon > ; Gaetan Rivet > ; Wu, Jingjing > Cc: dev@dpdk.org; Neil Horman ; Richardson, Bruce > > Subject: RE: [PATCH v3 7/7] app/testpmd:

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-19 Thread Matan Azrad
Hi Konstantin From: Ananyev, Konstantin, Friday, January 19, 2018 2:38 PM > To: Matan Azrad ; Thomas Monjalon > ; Gaetan Rivet ; Wu, > Jingjing > Cc: dev@dpdk.org; Neil Horman ; Richardson, > Bruce > Subject: RE: [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership > > Hi Matan, > > >

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-19 Thread Ananyev, Konstantin
Hi Matan, > -Original Message- > From: Matan Azrad [mailto:ma...@mellanox.com] > Sent: Thursday, January 18, 2018 4:35 PM > To: Thomas Monjalon ; Gaetan Rivet > ; Wu, Jingjing > Cc: dev@dpdk.org; Neil Horman ; Richardson, Bruce > ; Ananyev, Konstantin > > Subject: [PATCH v3 7/7] app/te

[dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-18 Thread Matan Azrad
Testpmd should not use ethdev ports which are managed by other DPDK entities. Set Testpmd ownership to each port which is not used by other entity and prevent any usage of ethdev ports which are not owned by Testpmd. Signed-off-by: Matan Azrad --- app/test-pmd/cmdline.c | 89 ++