Re: [dpdk-dev] [PATCH v4] ethdev: replace bus specific struct with generic dev

2018-04-05 Thread Ferruh Yigit
; Shreyansh Jain ; Legacy, Allain >> (Wind River) ; Tomasz Duszynski >> ; Thomas Monjalon >> Subject: Re: [dpdk-dev] [PATCH v4] ethdev: replace bus specific struct with >> generic dev >> >> On 4/3/2018 10:06 AM, David Marchand wrote: >>> On Mon, Apr 2, 201

Re: [dpdk-dev] [PATCH v4] ethdev: replace bus specific struct with generic dev

2018-04-04 Thread De Lara Guarch, Pablo
Monjalon > Subject: Re: [dpdk-dev] [PATCH v4] ethdev: replace bus specific struct with > generic dev > > On 4/3/2018 10:06 AM, David Marchand wrote: > > On Mon, Apr 2, 2018 at 6:13 PM, santosh > > wrote: > >> On Friday 30 March 2018 08:59 PM, David Marchand wrote:

Re: [dpdk-dev] [PATCH v4] ethdev: replace bus specific struct with generic dev

2018-04-03 Thread Ferruh Yigit
On 4/3/2018 10:06 AM, David Marchand wrote: > On Mon, Apr 2, 2018 at 6:13 PM, santosh > wrote: >> On Friday 30 March 2018 08:59 PM, David Marchand wrote: >>> I can see we enforce the driver name by putting it after the call to >>> .dev_infos_get. >>> http://dpdk.org/browse/dpdk/tree/lib/librte_eth

Re: [dpdk-dev] [PATCH v4] ethdev: replace bus specific struct with generic dev

2018-04-03 Thread David Marchand
On Mon, Apr 2, 2018 at 6:13 PM, santosh wrote: > On Friday 30 March 2018 08:59 PM, David Marchand wrote: >> I can see we enforce the driver name by putting it after the call to >> .dev_infos_get. >> http://dpdk.org/browse/dpdk/tree/lib/librte_ether/rte_ethdev.c#n2399 >> >> octeontx pmd seems to tr

Re: [dpdk-dev] [PATCH v4] ethdev: replace bus specific struct with generic dev

2018-04-02 Thread santosh
Hello David, On Friday 30 March 2018 08:59 PM, David Marchand wrote: > On Fri, Mar 30, 2018 at 5:17 PM, Ferruh Yigit wrote: >> Public struct rte_eth_dev_info has a "struct rte_pci_device" field in it >> although it is common for all ethdev in all buses. >> >> Replacing pci specific struct with g

Re: [dpdk-dev] [PATCH v4] ethdev: replace bus specific struct with generic dev

2018-04-02 Thread David Marchand
Hello Ferruh, On Fri, Mar 30, 2018 at 5:29 PM, David Marchand wrote: > On Fri, Mar 30, 2018 at 5:17 PM, Ferruh Yigit wrote: >> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c >> index 209796d46..68bdc3103 100644 >> --- a/lib/librte_ether/rte_ethdev.c >> +++ b/lib/librt

Re: [dpdk-dev] [PATCH v4] ethdev: replace bus specific struct with generic dev

2018-03-30 Thread David Marchand
On Fri, Mar 30, 2018 at 5:17 PM, Ferruh Yigit wrote: > Public struct rte_eth_dev_info has a "struct rte_pci_device" field in it > although it is common for all ethdev in all buses. > > Replacing pci specific struct with generic device struct and updating > places that are using pci device in a way

[dpdk-dev] [PATCH v4] ethdev: replace bus specific struct with generic dev

2018-03-30 Thread Ferruh Yigit
Public struct rte_eth_dev_info has a "struct rte_pci_device" field in it although it is common for all ethdev in all buses. Replacing pci specific struct with generic device struct and updating places that are using pci device in a way to get this information from generic device. Signed-off-by: F