Re: [dpdk-dev] [PATCH v4] examples/l2fwd: add cmdline option for forwarding port info

2020-07-05 Thread Thomas Monjalon
04/07/2020 15:36, Jerin Jacob: > On Mon, May 25, 2020 at 2:59 PM Bruce Richardson > wrote: > > > > On Sun, May 24, 2020 at 06:13:22PM +0200, Thomas Monjalon wrote: > > > Bruce, as maintainer of l2fwd example, any opinion about this change? > > > > > Assuming all previous discussion on it is resolv

Re: [dpdk-dev] [PATCH v4] examples/l2fwd: add cmdline option for forwarding port info

2020-07-04 Thread Jerin Jacob
On Mon, May 25, 2020 at 2:59 PM Bruce Richardson wrote: > > On Sun, May 24, 2020 at 06:13:22PM +0200, Thomas Monjalon wrote: > > Bruce, as maintainer of l2fwd example, any opinion about this change? > > > Assuming all previous discussion on it is resolved, I'm fine with this > patch, though I susp

Re: [dpdk-dev] [PATCH v4] examples/l2fwd: add cmdline option for forwarding port info

2020-05-25 Thread Bruce Richardson
On Sun, May 24, 2020 at 06:13:22PM +0200, Thomas Monjalon wrote: > Bruce, as maintainer of l2fwd example, any opinion about this change? > Assuming all previous discussion on it is resolved, I'm fine with this patch, though I suspect it will only make 20.08 now. Acked-by: Bruce Richardson > >

Re: [dpdk-dev] [PATCH v4] examples/l2fwd: add cmdline option for forwarding port info

2020-05-24 Thread Thomas Monjalon
Bruce, as maintainer of l2fwd example, any opinion about this change? 11/05/2020 02:23, Pavan Nikhilesh Bhagavatula: > Hi Vipin, > > >Hi Pavan, > > > >snipped > >> > > >> >Should we check & warn the user if > >> >1. port speed mismatch > >> >2. on different NUMA > >> >3. port pairs are physical

Re: [dpdk-dev] [PATCH v4] examples/l2fwd: add cmdline option for forwarding port info

2020-05-10 Thread Pavan Nikhilesh Bhagavatula
Hi Vipin, >Hi Pavan, > >snipped >> > >> >Should we check & warn the user if >> >1. port speed mismatch >> >2. on different NUMA >> >3. port pairs are physical and vdev like tap, and KNI (performance). >> > >> >> Sure, it can be a separate patch as it will be applicable for multiple >examples. >I b

Re: [dpdk-dev] [PATCH v4] examples/l2fwd: add cmdline option for forwarding port info

2020-05-01 Thread Varghese, Vipin
Hi Pavan, snipped > > > >Should we check & warn the user if > >1. port speed mismatch > >2. on different NUMA > >3. port pairs are physical and vdev like tap, and KNI (performance). > > > > Sure, it can be a separate patch as it will be applicable for multiple > examples. I believe this patch is

Re: [dpdk-dev] [PATCH v4] examples/l2fwd: add cmdline option for forwarding port info

2020-05-01 Thread Pavan Nikhilesh Bhagavatula
>Hi Vamsi & Pavan, > >I like this idea, couple of queries > >snipped >> +static int >> +check_port_pair_config(void) >> +{ >> +uint32_t port_pair_config_mask = 0; >> +uint32_t port_pair_mask = 0; >> +uint16_t index, i, portid; >> + >> +for (index = 0; index < nb_port_pair_params;

Re: [dpdk-dev] [PATCH v4] examples/l2fwd: add cmdline option for forwarding port info

2020-05-01 Thread Varghese, Vipin
Hi Vamsi & Pavan, I like this idea, couple of queries snipped > +static int > +check_port_pair_config(void) > +{ > + uint32_t port_pair_config_mask = 0; > + uint32_t port_pair_mask = 0; > + uint16_t index, i, portid; > + > + for (index = 0; index < nb_port_pair_params; index++) {

Re: [dpdk-dev] [PATCH v4] examples/l2fwd: add cmdline option for forwarding port info

2020-04-27 Thread Sunil Kumar Kori
t;; Akhil Goyal ; Tomasz >Kantecki ; Sunil Kumar Kori >; Pavan Nikhilesh Bhagavatula > >Cc: Andrzej Ostruszka [C] ; dev@dpdk.org; Vamsi >Krishna Attunuru >Subject: [dpdk-dev] [PATCH v4] examples/l2fwd: add cmdline option for >forwarding port info > >From: Vamsi Attunuru

[dpdk-dev] [PATCH v4] examples/l2fwd: add cmdline option for forwarding port info

2020-04-27 Thread pbhagavatula
From: Vamsi Attunuru Current l2fwd application statically configures adjacent ports as destination ports for forwarding the traffic. Add a portmap option to pass the forwarding port pair mapping which allows the user to configure forwarding port mapping. If no portmap argument is specified, des