[dpdk-dev] [PATCH v4] ixgbe_pmd: enforce RS bit on every EOP descriptor for devices newer than 82598

2015-10-27 Thread Vlad Zolotarov
dev at dpdk.org; Kirsher, Jeffrey T; Brandeburg, Jesse >> Subject: Re: [dpdk-dev] [PATCH v4] ixgbe_pmd: enforce RS bit on every EOP >> descriptor for devices newer than 82598 >> >> >> >> On 10/27/15 20:09, Thomas Monjalon wrote: >>> Any Follow-up to

[dpdk-dev] [PATCH v4] ixgbe_pmd: enforce RS bit on every EOP descriptor for devices newer than 82598

2015-10-27 Thread Vlad Zolotarov
On 10/27/15 20:09, Thomas Monjalon wrote: > Any Follow-up to this discussion? > Should we mark this patch as rejected? Hmmm... This patch fixes an obvious spec violation. Why would it be rejected? > > 2015-08-24 11:11, Vlad Zolotarov: >> On 08/20/15 18:37, Vlad Zolotarov wrote: >>> According t

[dpdk-dev] [PATCH v4] ixgbe_pmd: enforce RS bit on every EOP descriptor for devices newer than 82598

2015-10-27 Thread Ananyev, Konstantin
pdk-dev] [PATCH v4] ixgbe_pmd: enforce RS bit on every EOP > descriptor for devices newer than 82598 > > > > On 10/27/15 20:09, Thomas Monjalon wrote: > > Any Follow-up to this discussion? > > Should we mark this patch as rejected? > > Hmmm... This patch fixes an

[dpdk-dev] [PATCH v4] ixgbe_pmd: enforce RS bit on every EOP descriptor for devices newer than 82598

2015-10-27 Thread Thomas Monjalon
Any Follow-up to this discussion? Should we mark this patch as rejected? 2015-08-24 11:11, Vlad Zolotarov: > On 08/20/15 18:37, Vlad Zolotarov wrote: > > According to 82599 and x540 HW specifications RS bit *must* be > > set in the last descriptor of *every* packet. > > > > Before this patch there

[dpdk-dev] [PATCH v4] ixgbe_pmd: enforce RS bit on every EOP descriptor for devices newer than 82598

2015-10-27 Thread Brandeburg, Jesse
] ixgbe_pmd: enforce RS bit on every EOP descriptor for devices newer than 82598 On 10/27/15 20:09, Thomas Monjalon wrote: > Any Follow-up to this discussion? > Should we mark this patch as rejected? Hmmm... This patch fixes an obvious spec violation. Why would it be rejected? > > 2015

[dpdk-dev] [PATCH v4] ixgbe_pmd: enforce RS bit on every EOP descriptor for devices newer than 82598

2015-09-11 Thread Konstantin Ananyev
Hi Vlad, >> Unfortunately we are seeing a huge performance drop with that patch: >> On my box bi-directional traffic (64B packet) over one port can't reach even >> 11 Mpps. >Konstantin, could u clarify - u saw "only" 11 Mpps with v3 of this patch which >doesn't change the rs_thresh and only sets

[dpdk-dev] [PATCH v4] ixgbe_pmd: enforce RS bit on every EOP descriptor for devices newer than 82598

2015-08-24 Thread Vlad Zolotarov
On 08/20/15 18:37, Vlad Zolotarov wrote: > According to 82599 and x540 HW specifications RS bit *must* be > set in the last descriptor of *every* packet. > > Before this patch there were 3 types of Tx callbacks that were setting > RS bit every tx_rs_thresh descriptors. This patch introduces a set

[dpdk-dev] [PATCH v4] ixgbe_pmd: enforce RS bit on every EOP descriptor for devices newer than 82598

2015-08-20 Thread Vlad Zolotarov
According to 82599 and x540 HW specifications RS bit *must* be set in the last descriptor of *every* packet. Before this patch there were 3 types of Tx callbacks that were setting RS bit every tx_rs_thresh descriptors. This patch introduces a set of new callbacks, one for each type mentioned above