Re: [dpdk-dev] [PATCH v4] sched: make RED scaling configurable

2018-01-05 Thread Dewar, Alan
> > > > +int > > > > +rte_red_set_scaling(uint16_t max_red_queue_length); > > > > + > > > > +/** > > > > + * @brief Reset the RED scaling factor - only for use by RED > > > > +unit-tests > > > > + * > > > > + * @return Operation status > > > > + */ > > > > +void > > > > +rte_red_reset_scaling(void

Re: [dpdk-dev] [PATCH v4] sched: make RED scaling configurable

2018-01-04 Thread Dumitrescu, Cristian
> -Original Message- > From: Dewar, Alan [mailto:ad7...@intl.att.com] > Sent: Thursday, January 4, 2018 1:35 PM > To: Dumitrescu, Cristian ; > 'alangordonde...@gmail.com' > Cc: 'dev@dpdk.org' ; 'Alan Dewar' > Subject: RE: [PATCH v4] sched: make RED scaling configurable > > > > > > +int

Re: [dpdk-dev] [PATCH v4] sched: make RED scaling configurable

2018-01-04 Thread Dewar, Alan
Hi Cristian, > -Original Message- > From: Dumitrescu, Cristian [mailto:cristian.dumitre...@intel.com] > Sent: Tuesday, January 02, 2018 4:44 PM > To: alangordonde...@gmail.com > Cc: dev@dpdk.org; Alan Dewar > Subject: RE: [PATCH v4] sched: make RED scaling configurable > > Hi Alan, > > T

Re: [dpdk-dev] [PATCH v4] sched: make RED scaling configurable

2018-01-03 Thread Dumitrescu, Cristian
> > > +int > > > +rte_red_set_scaling(uint16_t max_red_queue_length); > > > + > > > +/** > > > + * @brief Reset the RED scaling factor - only for use by RED > > > +unit-tests > > > + * > > > + * @return Operation status > > > + */ > > > +void > > > +rte_red_reset_scaling(void); > > > > As stated ab

Re: [dpdk-dev] [PATCH v4] sched: make RED scaling configurable

2018-01-02 Thread Dumitrescu, Cristian
Hi Alan, Thanks for your work! I do have some comments (see below), but generally looks good to me. > -Original Message- > From: alangordonde...@gmail.com [mailto:alangordonde...@gmail.com] > Sent: Tuesday, October 3, 2017 10:22 AM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; Alan Dew

Re: [dpdk-dev] [PATCH v4] sched: make RED scaling configurable

2018-01-02 Thread Dumitrescu, Cristian
> -Original Message- > From: Dumitrescu, Cristian > Sent: Tuesday, October 3, 2017 6:16 PM > To: alangordonde...@gmail.com; Kantecki, Tomasz > > Cc: dev@dpdk.org; Alan Dewar > Subject: RE: [PATCH v4] sched: make RED scaling configurable > > Adding Tomasz. > > > -Original Message--

Re: [dpdk-dev] [PATCH v4] sched: make RED scaling configurable

2017-10-03 Thread Dumitrescu, Cristian
Adding Tomasz. > -Original Message- > From: alangordonde...@gmail.com [mailto:alangordonde...@gmail.com] > Sent: Tuesday, October 3, 2017 10:22 AM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; Alan Dewar > Subject: [PATCH v4] sched: make RED scaling configurable > > From: Alan Dewar >

[dpdk-dev] [PATCH v4] sched: make RED scaling configurable

2017-10-03 Thread alangordondewar
From: Alan Dewar The RED code stores the weighted moving average in a 32-bit integer as a pseudo fixed-point floating number with 10 fractional bits. Twelve other bits are used to encode the filter weight, leaving just 10 bits for the queue length. This limits the maximum queue length supported