Re: [dpdk-dev] [PATCH v4] vhost_user: protect active rings from async ring changes

2017-12-21 Thread Victor Kaplansky
an" > Sent: Wednesday, December 20, 2017 10:19:45 PM > Subject: Re: [dpdk-dev] [PATCH v4] vhost_user: protect active rings from > async ring changes > > On Wed, 20 Dec 2017 15:06:30 -0500 (EST) > Victor Kaplansky wrote: > > > > Wrapping locking inline's

Re: [dpdk-dev] [PATCH v4] vhost_user: protect active rings from async ring changes

2017-12-20 Thread Stephen Hemminger
On Wed, 20 Dec 2017 15:06:30 -0500 (EST) Victor Kaplansky wrote: > > Wrapping locking inline's adds nothing and makes life harder > > for static analysis tools. > > Yep. In this case it inhibits the details of how the locking is > implemented (e.g. the name of the lock). It also facilitates >

Re: [dpdk-dev] [PATCH v4] vhost_user: protect active rings from async ring changes

2017-12-20 Thread Victor Kaplansky
Tan" > Sent: Wednesday, December 20, 2017 9:06:16 PM > Subject: Re: [dpdk-dev] [PATCH v4] vhost_user: protect active rings from > async ring changes > > On Wed, 20 Dec 2017 16:37:52 +0200 > Victor Kaplansky wrote: > > > When performing live migration or memory hot

Re: [dpdk-dev] [PATCH v4] vhost_user: protect active rings from async ring changes

2017-12-20 Thread Stephen Hemminger
On Wed, 20 Dec 2017 16:37:52 +0200 Victor Kaplansky wrote: > When performing live migration or memory hot-plugging, > the changes to the device and vrings made by message handler > done independently from vring usage by PMD threads. > > This causes for example segfaults during live-migration > w

[dpdk-dev] [PATCH v4] vhost_user: protect active rings from async ring changes

2017-12-20 Thread Victor Kaplansky
When performing live migration or memory hot-plugging, the changes to the device and vrings made by message handler done independently from vring usage by PMD threads. This causes for example segfaults during live-migration with MQ enable, but in general virtually any request sent by qemu changing