Re: [dpdk-dev] [PATCH v4 0/5] integrate librte_ipsec SAD into ipsec-secgw

2020-01-23 Thread Ananyev, Konstantin
> > > > > > > The SA lookup logic and management is purely requirement based > > > > > > > for the > > > > > > application. > > > > > > >The application may only cater to <128 SAs which can > > > > > > > be handled based on the current logic. > > > > > > > > > > > > Not always, current implementa

Re: [dpdk-dev] [PATCH v4 0/5] integrate librte_ipsec SAD into ipsec-secgw

2020-01-23 Thread Thomas Monjalon
23/01/2020 13:56, Akhil Goyal: > Hi Konstantin, > > > > Hi Akhil, > > > > > > > > Hi Vladimir, > > > > > > The SA lookup logic and management is purely requirement based for > > > > > > the > > > > > application. > > > > > >The application may only cater to <128 SAs which can > > > > > > be hand

Re: [dpdk-dev] [PATCH v4 0/5] integrate librte_ipsec SAD into ipsec-secgw

2020-01-23 Thread Akhil Goyal
Hi Konstantin, > > Hi Akhil, > > > > > > Hi Vladimir, > > > > > The SA lookup logic and management is purely requirement based for the > > > > application. > > > > >The application may only cater to <128 SAs which can > > > > > be handled based on the current logic. > > > > > > > > Not always, cu

Re: [dpdk-dev] [PATCH v4 0/5] integrate librte_ipsec SAD into ipsec-secgw

2020-01-23 Thread Ananyev, Konstantin
Hi Akhil, > > > > Hi Vladimir, > > > > The SA lookup logic and management is purely requirement based for the > > > application. > > > >The application may only cater to <128 SAs which can > > > > be handled based on the current logic. > > > > > > Not always, current implementation can handle < 12

Re: [dpdk-dev] [PATCH v4 0/5] integrate librte_ipsec SAD into ipsec-secgw

2020-01-23 Thread Akhil Goyal
Hi All, > > Hi Konstantin, > > > > Hi Akhil, > > > > > Hi Vladimir, > > > The SA lookup logic and management is purely requirement based for the > > application. > > >The application may only cater to <128 SAs which can > > > be handled based on the current logic. > > > > Not always, current imple

Re: [dpdk-dev] [PATCH v4 0/5] integrate librte_ipsec SAD into ipsec-secgw

2020-01-21 Thread Akhil Goyal
Hi Konstantin, > > Hi Akhil, > > > Hi Vladimir, > > The SA lookup logic and management is purely requirement based for the > application. > >The application may only cater to <128 SAs which can > > be handled based on the current logic. > > Not always, current implementation can handle < 128 SA,

Re: [dpdk-dev] [PATCH v4 0/5] integrate librte_ipsec SAD into ipsec-secgw

2020-01-20 Thread Anoob Joseph
Hi Vladimir, Akhil, Marvell is also observing 10-15% drop with the SAD change. I agree with Akhil's opinion and we are not in favor of making this change. Thanks, Anoob From: Akhil Goyal Sent: Monday, January 20, 2020 12:14 PM To: Medvedkin, Vladimir ; dev@dpdk.org Cc: konstantin.anan...@inte

Re: [dpdk-dev] [PATCH v4 0/5] integrate librte_ipsec SAD into ipsec-secgw

2020-01-19 Thread Akhil Goyal
Hi Vladimir, The SA lookup logic and management is purely requirement based for the application. The application may only cater to <128 SAs which can be handled based on the current logic. –single-sa option cannot handle this. Sample applications in DPDK are there to showcase the best a hardware

Re: [dpdk-dev] [PATCH v4 0/5] integrate librte_ipsec SAD into ipsec-secgw

2020-01-17 Thread Medvedkin, Vladimir
Hi Akhil, Indeed with our tests we also seeing ~15% perf drop for small packets (~90B) and ~3-4% drop for 1KB packets. While I am looking on a ways to minimize the drop, I think it would be hard, if possible at all to eliminate it completely. Reason for that: current SAD implementation is comp

Re: [dpdk-dev] [PATCH v4 0/5] integrate librte_ipsec SAD into ipsec-secgw

2020-01-17 Thread Akhil Goyal
Hi Vladimir, The lookup logic for SAD has been brought more closer to real use case, but it looks very high on CPU and should be optimized. We cannot have 10-15% drop because of this change in SA lookup for small packet(82B) sizes where CPU is bottleneck. For large packet sizes it will not impa

Re: [dpdk-dev] [PATCH v4 0/5] integrate librte_ipsec SAD into ipsec-secgw

2020-01-15 Thread Akhil Goyal
Hi Vladimir, There is more than 10% drop with this patchset on NXP hardware with both legacy mode and the ipsec lib mode. This would need some debugging. Didn't you see any drop on intel? Regards, Akhil > -Original Message- > From: Vladimir Medvedkin > Sent: Tuesday, January 14, 2020 7

[dpdk-dev] [PATCH v4 0/5] integrate librte_ipsec SAD into ipsec-secgw

2020-01-14 Thread Vladimir Medvedkin
This series integrates SA database (SAD) capabilities from ipsec library. The goal is to make ipsec-secgw RFC compliant regarding inbound SAD. Also patch series removes hardcoded limitation for maximum number of SA's and SP's. v4: - put tunnel SA's into SAD with SPI_ONLY type for performance reas