Re: [dpdk-dev] [PATCH v4 05/10] ipsec: add SA data-path API

2018-12-21 Thread Akhil Goyal
On 12/20/2018 3:47 PM, Ananyev, Konstantin wrote: > >>> + * @param ss >>> + * Pointer to the *rte_ipsec_session* object >>> + * @return >>> + * - Zero if operation completed successfully. >>> + * - -EINVAL if the parameters are invalid. >>> + */ >>> +int __rte_experimental >>> +rte_ipsec_se

Re: [dpdk-dev] [PATCH v4 05/10] ipsec: add SA data-path API

2018-12-20 Thread Ananyev, Konstantin
Hi Akhil, > > Hi Konstantin, > > Sorry for a late review. I was on unplanned leave for more than 2 weeks. No worries, thanks for review. Comments/answers inline. Konstantin > > +/** > > + * Checks that inside given rte_ipsec_session crypto/security fields > > + * are filled correctly and setu

Re: [dpdk-dev] [PATCH v4 05/10] ipsec: add SA data-path API

2018-12-19 Thread Akhil Goyal
Hi Konstantin, Sorry for a late review. I was on unplanned leave for more than 2 weeks. On 12/14/2018 9:53 PM, Konstantin Ananyev wrote: > Introduce Security Association (SA-level) data-path API > Operates at SA level, provides functions to: > - initialize/teardown SA object > - process

[dpdk-dev] [PATCH v4 05/10] ipsec: add SA data-path API

2018-12-14 Thread Konstantin Ananyev
Introduce Security Association (SA-level) data-path API Operates at SA level, provides functions to: - initialize/teardown SA object - process inbound/outbound ESP/AH packets associated with the given SA (decrypt/encrypt, authenticate, check integrity, add/remove ESP/AH related