Re: [dpdk-dev] [PATCH v4 09/20] eal/dev: implement device iteration initialization

2018-03-31 Thread Gaëtan Rivet
On Fri, Mar 30, 2018 at 04:22:15PM +, Wiles, Keith wrote: > > > > On Mar 30, 2018, at 10:53 AM, Gaëtan Rivet wrote: > > > > Hello Keith, > > Hello Gaëtan, > > >>> + layers[i].kvlist = rte_kvargs_parse(copy, NULL); > >>> + free(copy); > >> > >> I am sorry this method of no

Re: [dpdk-dev] [PATCH v4 09/20] eal/dev: implement device iteration initialization

2018-03-30 Thread Wiles, Keith
> On Mar 30, 2018, at 10:53 AM, Gaëtan Rivet wrote: > > Hello Keith, Hello Gaëtan, >>> + layers[i].kvlist = rte_kvargs_parse(copy, NULL); >>> + free(copy); >> >> I am sorry this method of not adding blank lines is a bit silly and we need >> to rethink at least adding a f

Re: [dpdk-dev] [PATCH v4 09/20] eal/dev: implement device iteration initialization

2018-03-30 Thread Gaëtan Rivet
Hello Keith, On Fri, Mar 30, 2018 at 03:22:59PM +, Wiles, Keith wrote: > > > > On Mar 29, 2018, at 4:23 PM, Gaetan Rivet wrote: > > > > Parse a device description. > > Split this description in their relevant part for each layers. > > No dynamic allocation is performed. > > > > Signed-off

Re: [dpdk-dev] [PATCH v4 09/20] eal/dev: implement device iteration initialization

2018-03-30 Thread Wiles, Keith
> On Mar 29, 2018, at 4:23 PM, Gaetan Rivet wrote: > > Parse a device description. > Split this description in their relevant part for each layers. > No dynamic allocation is performed. > > Signed-off-by: Gaetan Rivet > --- > lib/Makefile| 1 + > lib/librte_eal/bs

[dpdk-dev] [PATCH v4 09/20] eal/dev: implement device iteration initialization

2018-03-29 Thread Gaetan Rivet
Parse a device description. Split this description in their relevant part for each layers. No dynamic allocation is performed. Signed-off-by: Gaetan Rivet --- lib/Makefile| 1 + lib/librte_eal/bsdapp/eal/Makefile | 1 + lib/librte_eal/common/eal_common_dev.c