> >
> > > > I have applied your
> > > > suggestion in 6/6 in v6 along with my corrections. The
> > > > rte_ring_elem test cases are added in 3/6. I have verified that they are
> running fine (they are done for 64b alone, will add more). Hopefully, there
> are
> no more errors.
> >
> > Applied v6
...@microsoft.com'
> ; 'jer...@marvell.com' ;
> Richardson, Bruce ;
> 'david.march...@redhat.com' ;
> 'pbhagavat...@marvell.com' ;
> 'dev@dpdk.org' ; 'Dharmik Thakkar' ;
> 'Ruifeng Wang (Arm Technology China)'
> > I have applied your
> > suggestion in 6/6 in v6 along with my corrections. The rte_ring_elem test
> > cases are added in 3/6. I have verified that they are running
> > fine (they are done for 64b alone, will add more). Hopefully, there are no
> > more errors.
Applied v6 and re-run the test
> >
> > fix patch
> > ===
> >
> > From a2be5a9b136333a56d466ef042c655e522ca7012 Mon Sep 17 00:00:00
> > 2001
> > From: Konstantin Ananyev
> > Date: Fri, 18 Oct 2019 15:50:43 +0100
> > Subject: [PATCH] fix1
> >
> > Signed-off-by: Konstantin Ananyev
> > ---
> > lib/librte_ring/rte_ring_elem.
>
> Hi everyone,
>
>
> > > > >>> I tried this. On x86 (Xeon(R) Gold 6132 CPU @ 2.60GHz), the
> > > > >>> results are as
> > > > >> follows. The numbers in brackets are with the code on master.
> > > > >>> gcc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
> > > > >>>
> > > > >>> RTE>>ring_perf_elem_autot
> > >
> > > > Subject: Re: [PATCH v4 1/2] lib/ring: apis to support configurable
> > > > element size
> > > >
> > > > >>> I tried this. On x86 (Xeon(R) Gold 6132 CPU @ 2.60GHz), the
> > > > >>> results are as
> > > > >> follows. The numbers in brackets are with the code on master.
> > > > >>> gcc (
> Subject: RE: [dpdk-dev] [PATCH v4 1/2] lib/ring: apis to support configurable
> element size
>
>
> Hi everyone,
>
>
> > > > >>> I tried this. On x86 (Xeon(R) Gold 6132 CPU @ 2.60GHz), the
> > > > >>> results are as
> >
Tried this on a Power9 platform (3.6GHz), with two numa nodes and 16
cores/node (SMT=4). Applied all 3 patches in v5, test results are as
follows:
RTE>>ring_perf_elem_autotest
### Testing single element and burst enq/deq ### SP/SC single enq/dequeue:
42 MP/MC single enq/dequeue: 59 SP/SC burs
Hi everyone,
> > > >>> I tried this. On x86 (Xeon(R) Gold 6132 CPU @ 2.60GHz), the results
> > > >>> are as
> > > >> follows. The numbers in brackets are with the code on master.
> > > >>> gcc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
> > > >>>
> > > >>> RTE>>ring_perf_elem_autotest
> > > >>> ### Te
On Fri, Oct 18, 2019 at 1:34 PM Jerin Jacob wrote:
>
> On Fri, Oct 18, 2019 at 8:48 AM Honnappa Nagarahalli
> wrote:
> >
> >
> >
> > > Subject: Re: [PATCH v4 1/2] lib/ring: apis to support configurable element
> > > size
> > >
> > > >>> I tried this. On x86 (Xeon(R) Gold 6132 CPU @ 2.60GHz), the
On Fri, Oct 18, 2019 at 8:48 AM Honnappa Nagarahalli
wrote:
>
>
>
> > Subject: Re: [PATCH v4 1/2] lib/ring: apis to support configurable element
> > size
> >
> > >>> I tried this. On x86 (Xeon(R) Gold 6132 CPU @ 2.60GHz), the results
> > >>> are as
> > >> follows. The numbers in brackets are with
> Subject: Re: [PATCH v4 1/2] lib/ring: apis to support configurable element
> size
>
> >>> I tried this. On x86 (Xeon(R) Gold 6132 CPU @ 2.60GHz), the results
> >>> are as
> >> follows. The numbers in brackets are with the code on master.
> >>> gcc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
> >>>
>
I tried this. On x86 (Xeon(R) Gold 6132 CPU @ 2.60GHz), the results are as
follows. The numbers in brackets are with the code on master.
gcc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
RTE>>ring_perf_elem_autotest
### Testing single element and burst enq/deq ### SP/SC single
enq/dequeue: 5 MP/MC sing
+ David Christensen for Power architecture
> > >
> > > > It
> > > > would mean extra work for the users.
> > > >
> > > > > 2. A lot of code duplication with these 3 copies of
> > > > > ENQUEUE/DEQUEUE macros.
> > > > >
> > > > > Looking at ENQUEUE/DEQUEUE macros, I can see that main loop
> > > >
> > > > > > Current APIs assume ring elements to be pointers. However, in
> > > > > > many use cases, the size can be different. Add new APIs to
> > > > > > support configurable ring element sizes.
> > > > > >
> > > > > > Signed-off-by: Honnappa Nagarahalli
> > > > > >
> > > > > > Reviewed-by: D
> Hi Honnappa,
>
> > > > >
> > > > > Current APIs assume ring elements to be pointers. However, in
> > > > > many use cases, the size can be different. Add new APIs to
> > > > > support configurable ring element sizes.
> > > > >
> > > > > Signed-off-by: Honnappa Nagarahalli
> > > > >
> > > > >
Hi Honnappa,
> > > >
> > > > Current APIs assume ring elements to be pointers. However, in many
> > > > use cases, the size can be different. Add new APIs to support
> > > > configurable ring element sizes.
> > > >
> > > > Signed-off-by: Honnappa Nagarahalli
> > > > Reviewed-by: Dharmik Thakka
Hi Konstantin,
Thank you for the feedback.
>
> > >
> > > Current APIs assume ring elements to be pointers. However, in many
> > > use cases, the size can be different. Add new APIs to support
> > > configurable ring element sizes.
> > >
> > > Signed-off-by: Honnappa Nagarahalli
> > > R
> >
> > Current APIs assume ring elements to be pointers. However, in many use
> > cases,
> > the size can be different. Add new APIs to support configurable ring element
> > sizes.
> >
> > Signed-off-by: Honnappa Nagarahalli
> > Reviewed-by: Dharmik Thakkar
> > Reviewed-by: Gavin Hu
> > Revi
Hi Bruce, Konstantin, Stephen,
Appreciate if you could provide feedback on this.
Thanks,
Honnappa
> -Original Message-
> From: Honnappa Nagarahalli
> Sent: Tuesday, October 8, 2019 9:47 PM
> To: olivier.m...@6wind.com; sthem...@microsoft.com; jer...@marvell.com;
> bruce.richard..
Current APIs assume ring elements to be pointers. However, in many
use cases, the size can be different. Add new APIs to support
configurable ring element sizes.
Signed-off-by: Honnappa Nagarahalli
Reviewed-by: Dharmik Thakkar
Reviewed-by: Gavin Hu
Reviewed-by: Ruifeng Wang
---
lib/librte_rin
21 matches
Mail list logo
