Re: [dpdk-dev] [PATCH v4 1/2] mbuf: support attaching external buffer to mbuf

2018-04-25 Thread Yongseok Koh
On Wed, Apr 25, 2018 at 10:00:10PM +0200, Olivier Matz wrote: > On Wed, Apr 25, 2018 at 09:19:32AM +, Yongseok Koh wrote: > > > On Apr 25, 2018, at 2:08 AM, Yongseok Koh wrote: > > >> On Apr 25, 2018, at 1:28 AM, Olivier Matz wrote: > > >> > > >> Hi Yongseok, > > >> > > >> On Tue, Apr 24, 2

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: support attaching external buffer to mbuf

2018-04-25 Thread Olivier Matz
On Wed, Apr 25, 2018 at 09:19:32AM +, Yongseok Koh wrote: > > On Apr 25, 2018, at 2:08 AM, Yongseok Koh wrote: > >> On Apr 25, 2018, at 1:28 AM, Olivier Matz wrote: > >> > >> Hi Yongseok, > >> > >> On Tue, Apr 24, 2018 at 06:02:44PM +0200, Olivier Matz wrote: > > @@ -688,14 +704,33 @@ r

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: support attaching external buffer to mbuf

2018-04-25 Thread Yongseok Koh
On Wed, Apr 25, 2018 at 05:45:34PM +0300, Andrew Rybchenko wrote: > On 04/25/2018 02:34 AM, Yongseok Koh wrote: > > On Tue, Apr 24, 2018 at 09:15:38PM +0200, Olivier Matz wrote: > > > On Tue, Apr 24, 2018 at 09:21:00PM +0300, Andrew Rybchenko wrote: > > > > On 04/24/2018 07:02 PM, Olivier Matz wrot

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: support attaching external buffer to mbuf

2018-04-25 Thread Stephen Hemminger
On Tue, 24 Apr 2018 22:22:45 +0200 Thomas Monjalon wrote: > > > > > > I guess the problem that it changes INDIRECT semantics since EXTBUF > > > is added as well. I think strictly speaking it is an API change. > > > Is it OK to make it without announcement? > > > > In any case, there will be a

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: support attaching external buffer to mbuf

2018-04-25 Thread Andrew Rybchenko
On 04/25/2018 02:34 AM, Yongseok Koh wrote: On Tue, Apr 24, 2018 at 09:15:38PM +0200, Olivier Matz wrote: On Tue, Apr 24, 2018 at 09:21:00PM +0300, Andrew Rybchenko wrote: On 04/24/2018 07:02 PM, Olivier Matz wrote: + m->ol_flags |= EXT_ATTACHED_MBUF; + m->shinfo = shinfo; + +

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: support attaching external buffer to mbuf

2018-04-25 Thread Yongseok Koh
> On Apr 25, 2018, at 2:08 AM, Yongseok Koh wrote: >> On Apr 25, 2018, at 1:28 AM, Olivier Matz wrote: >> >> Hi Yongseok, >> >> On Tue, Apr 24, 2018 at 06:02:44PM +0200, Olivier Matz wrote: > @@ -688,14 +704,33 @@ rte_mbuf_to_baddr(struct rte_mbuf *md) > } > /** > + * Returns TR

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: support attaching external buffer to mbuf

2018-04-25 Thread Yongseok Koh
> On Apr 25, 2018, at 1:28 AM, Olivier Matz wrote: > > Hi Yongseok, > > On Tue, Apr 24, 2018 at 06:02:44PM +0200, Olivier Matz wrote: @@ -688,14 +704,33 @@ rte_mbuf_to_baddr(struct rte_mbuf *md) } /** + * Returns TRUE if given mbuf is cloned by mbuf indirection, or FALSE

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: support attaching external buffer to mbuf

2018-04-25 Thread Olivier Matz
Hi Yongseok, On Tue, Apr 24, 2018 at 06:02:44PM +0200, Olivier Matz wrote: > > > @@ -688,14 +704,33 @@ rte_mbuf_to_baddr(struct rte_mbuf *md) > > > } > > > /** > > > + * Returns TRUE if given mbuf is cloned by mbuf indirection, or FALSE > > > + * otherwise. > > > + * > > > + * If a mbuf has it

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: support attaching external buffer to mbuf

2018-04-25 Thread Olivier Matz
On Tue, Apr 24, 2018 at 02:53:41PM -0700, Yongseok Koh wrote: > On Tue, Apr 24, 2018 at 10:22:45PM +0200, Thomas Monjalon wrote: > > 24/04/2018 21:15, Olivier Matz: > > > On Tue, Apr 24, 2018 at 09:21:00PM +0300, Andrew Rybchenko wrote: > > > > On 04/24/2018 07:02 PM, Olivier Matz wrote: > > > > >

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: support attaching external buffer to mbuf

2018-04-24 Thread Yongseok Koh
On Tue, Apr 24, 2018 at 09:15:38PM +0200, Olivier Matz wrote: > On Tue, Apr 24, 2018 at 09:21:00PM +0300, Andrew Rybchenko wrote: > > On 04/24/2018 07:02 PM, Olivier Matz wrote: > > > Hi Andrew, Yongseok, > > > > > > On Tue, Apr 24, 2018 at 03:28:33PM +0300, Andrew Rybchenko wrote: > > > > On 04/2

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: support attaching external buffer to mbuf

2018-04-24 Thread Yongseok Koh
On Tue, Apr 24, 2018 at 03:28:33PM +0300, Andrew Rybchenko wrote: > On 04/24/2018 04:38 AM, Yongseok Koh wrote: [...] > > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h > > index 06eceba37..7f6507a66 100644 > > --- a/lib/librte_mbuf/rte_mbuf.h > > +++ b/lib/librte_mbuf/rte_mbu

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: support attaching external buffer to mbuf

2018-04-24 Thread Thomas Monjalon
24/04/2018 23:53, Yongseok Koh: > On Tue, Apr 24, 2018 at 10:22:45PM +0200, Thomas Monjalon wrote: > > 24/04/2018 21:15, Olivier Matz: > > > On Tue, Apr 24, 2018 at 09:21:00PM +0300, Andrew Rybchenko wrote: > > > > On 04/24/2018 07:02 PM, Olivier Matz wrote: > > > > > On Tue, Apr 24, 2018 at 03:28:

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: support attaching external buffer to mbuf

2018-04-24 Thread Yongseok Koh
On Tue, Apr 24, 2018 at 10:22:45PM +0200, Thomas Monjalon wrote: > 24/04/2018 21:15, Olivier Matz: > > On Tue, Apr 24, 2018 at 09:21:00PM +0300, Andrew Rybchenko wrote: > > > On 04/24/2018 07:02 PM, Olivier Matz wrote: > > > > On Tue, Apr 24, 2018 at 03:28:33PM +0300, Andrew Rybchenko wrote: > > >

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: support attaching external buffer to mbuf

2018-04-24 Thread Thomas Monjalon
24/04/2018 21:15, Olivier Matz: > On Tue, Apr 24, 2018 at 09:21:00PM +0300, Andrew Rybchenko wrote: > > On 04/24/2018 07:02 PM, Olivier Matz wrote: > > > On Tue, Apr 24, 2018 at 03:28:33PM +0300, Andrew Rybchenko wrote: > > > > On 04/24/2018 04:38 AM, Yongseok Koh wrote: > > > > > + * Returns TRUE

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: support attaching external buffer to mbuf

2018-04-24 Thread Olivier Matz
On Tue, Apr 24, 2018 at 09:21:00PM +0300, Andrew Rybchenko wrote: > On 04/24/2018 07:02 PM, Olivier Matz wrote: > > Hi Andrew, Yongseok, > > > > On Tue, Apr 24, 2018 at 03:28:33PM +0300, Andrew Rybchenko wrote: > > > On 04/24/2018 04:38 AM, Yongseok Koh wrote: > > > > This patch introduces a new w

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: support attaching external buffer to mbuf

2018-04-24 Thread Olivier Matz
Hi Andrew, Yongseok, On Tue, Apr 24, 2018 at 03:28:33PM +0300, Andrew Rybchenko wrote: > On 04/24/2018 04:38 AM, Yongseok Koh wrote: > > This patch introduces a new way of attaching an external buffer to a mbuf. > > > > Attaching an external buffer is quite similar to mbuf indirection in > > repl

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: support attaching external buffer to mbuf

2018-04-24 Thread Andrew Rybchenko
On 04/24/2018 04:38 AM, Yongseok Koh wrote: This patch introduces a new way of attaching an external buffer to a mbuf. Attaching an external buffer is quite similar to mbuf indirection in replacing buffer addresses and length of a mbuf, but a few differences: - When an indirect mbuf is attach

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: support attaching external buffer to mbuf

2018-04-24 Thread Yongseok Koh
On Mon, Apr 23, 2018 at 10:01:07PM -0700, Stephen Hemminger wrote: > On Mon, 23 Apr 2018 18:38:53 -0700 > Yongseok Koh wrote: > > > This patch introduces a new way of attaching an external buffer to a mbuf. > > > > Attaching an external buffer is quite similar to mbuf indirection in > > replacin

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: support attaching external buffer to mbuf

2018-04-23 Thread Stephen Hemminger
On Mon, 23 Apr 2018 18:38:53 -0700 Yongseok Koh wrote: > This patch introduces a new way of attaching an external buffer to a mbuf. > > Attaching an external buffer is quite similar to mbuf indirection in > replacing buffer addresses and length of a mbuf, but a few differences: > - When an ind

[dpdk-dev] [PATCH v4 1/2] mbuf: support attaching external buffer to mbuf

2018-04-23 Thread Yongseok Koh
This patch introduces a new way of attaching an external buffer to a mbuf. Attaching an external buffer is quite similar to mbuf indirection in replacing buffer addresses and length of a mbuf, but a few differences: - When an indirect mbuf is attached, refcnt of the direct mbuf would be 2 as