Re: [dpdk-dev] [PATCH v4 1/3] compress/isal: enable checksum support in driver

2018-12-17 Thread Varghese, Vipin
Thanks for the update > -Original Message- > From: Daly, Lee > Sent: Monday, December 17, 2018 2:50 PM > To: Varghese, Vipin ; akhil.go...@nxp.com > Cc: dev@dpdk.org; Trahe, Fiona > Subject: RE: [dpdk-dev] [PATCH v4 1/3] compress/isal: enable checksum > support in

Re: [dpdk-dev] [PATCH v4 1/3] compress/isal: enable checksum support in driver

2018-12-17 Thread Daly, Lee
Hi Vipin, thanks for the question. > -Original Message- > From: Varghese, Vipin > Sent: Monday, December 17, 2018 8:20 AM > To: Daly, Lee ; akhil.go...@nxp.com > Cc: dev@dpdk.org; Daly, Lee > Subject: RE: [dpdk-dev] [PATCH v4 1/3] compress/isal: enable checksum &

Re: [dpdk-dev] [PATCH v4 1/3] compress/isal: enable checksum support in driver

2018-12-17 Thread Varghese, Vipin
Hi Lee, Apologies if the logic is already done for my query snipped > + /* Set private xform checksum */ > + switch (xform->compress.chksum) { > + /* Raw deflate by default */ Does the user have to choose RTE_COMP_CHECKSUM_NONE while creating compress/isal ins

[dpdk-dev] [PATCH v4 1/3] compress/isal: enable checksum support in driver

2018-12-14 Thread Lee Daly
This patch adds checksum support in the ISA-L PMD for both compression and decompression. CRC32 is supported as well as Adler32. V2: Documentation Changes V3: Added Release note V4: Removed dependency on offset unit test Signed-off-by: Lee Daly Acked-by: Fiona Trahe --- drivers/compress/isal/