Re: [dpdk-dev] [PATCH v4 1/3] ethdev: modify rte API for single flow dump

2021-04-14 Thread Thomas Monjalon
14/04/2021 11:07, Haifei Luo: > Hi Thomas, > I will remove it from prog_guide/rte_flow.rst. Is it okay ? Thank you. This is more a question for Ori. In case he is not available, yes I think it is better to skip rte_flow.rst in this patch as it doesn't bring added value. Note: please avoid top

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: modify rte API for single flow dump

2021-04-14 Thread Haifei Luo
HI Thomas, #1, okay , will modify title as " ethdev: dump single flow rule " . #2, yes, it can pass NULL. Will modify as you described. Thank you so much for the comments. -Original Message- From: Thomas Monjalon Sent: Wednesday, April 14, 2021 4:58 PM To: Haifei Luo Cc: dev@dpd

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: modify rte API for single flow dump

2021-04-14 Thread Haifei Luo
Hi Thomas, I will remove it from prog_guide/rte_flow.rst. Is it okay ? Thank you. -Original Message- From: Thomas Monjalon Sent: Wednesday, April 14, 2021 5:01 PM To: Ori Kam Cc: dev@dpdk.org; Haifei Luo ; Slava Ovsiienko ; Raslan Darawsheh ; Xueming(Steven) Li ; Haifei Luo ; aji

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: modify rte API for single flow dump

2021-04-14 Thread Thomas Monjalon
14/04/2021 10:41, Haifei Luo: > Previous implementations support dump all the flows. Add new arg > rte_flow in rte_flow_dev_dump to dump one flow. > > Signed-off-by: Haifei Luo > Acked-by: Ajit Khaparde > Acked-by: Ori Kam [...] > +Dump > +~ > + > +Dump information for all or one flows. > +

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: modify rte API for single flow dump

2021-04-14 Thread Thomas Monjalon
About the title, what is "rte API"? I guess you mean DPDK API with rte prefix. But given all DPDK API have rte prefix, and this patch is for DPDK, you can just say "API". So the title can be: ethdev: modify API for single flow dump But it can look as single flow dump was possible before,

[dpdk-dev] [PATCH v4 1/3] ethdev: modify rte API for single flow dump

2021-04-14 Thread Haifei Luo
Previous implementations support dump all the flows. Add new arg rte_flow in rte_flow_dev_dump to dump one flow. Signed-off-by: Haifei Luo Acked-by: Ajit Khaparde Acked-by: Ori Kam --- app/test-pmd/config.c| 2 +- doc/guides/nics/mlx5.rst | 9 ++--- doc/guides