Two opens here, the trivial one is i think it is not good practice to
explicitly inline non performance critical functions in c file, even if
it will be done by compiler anyway.
The critical one i have concern is whether it will introduce
inconsistency if we call fd_install on a fd that is just clo
On Mon, May 18, 2015 at 9:06 AM, Xie, Huawei wrote:
> On 5/7/2015 9:17 PM, Pavel Boldin wrote:
>
>
> On Thu, May 7, 2015 at 10:57 AM, Xie, Huawei huawei.xie at intel.com>> wrote:
> On 4/3/2015 1:02 AM, Pavel Boldin wrote:
> > Move ioctl `EVENTFD_COPY' handler code to an inline function.
> Pavel:
On 5/7/2015 9:17 PM, Pavel Boldin wrote:
On Thu, May 7, 2015 at 10:57 AM, Xie, Huawei mailto:huawei.xie at intel.com>> wrote:
On 4/3/2015 1:02 AM, Pavel Boldin wrote:
> Move ioctl `EVENTFD_COPY' handler code to an inline function.
Pavel:
There is no necessity to inline this function.
Xie, there i
On Thu, May 7, 2015 at 10:57 AM, Xie, Huawei wrote:
> On 4/3/2015 1:02 AM, Pavel Boldin wrote:
> > Move ioctl `EVENTFD_COPY' handler code to an inline function.
> Pavel:
> There is no necessity to inline this function.
>
Xie, there is even no necessity to split this in a five piece patchseries.
I
On 4/3/2015 1:02 AM, Pavel Boldin wrote:
> Move ioctl `EVENTFD_COPY' handler code to an inline function.
Pavel:
There is no necessity to inline this function.
/huawei
Move ioctl `EVENTFD_COPY' handler code to an inline function.
---
lib/librte_vhost/eventfd_link/eventfd_link.c | 171 ++-
1 file changed, 89 insertions(+), 82 deletions(-)
diff --git a/lib/librte_vhost/eventfd_link/eventfd_link.c
b/lib/librte_vhost/eventfd_link/eventfd_li
6 matches
Mail list logo
