Re: [dpdk-dev] [PATCH v4 2/2] net/virtio: move VLAN tag insertion to Tx prepare

2019-06-20 Thread Maxime Coquelin
On 6/17/19 1:31 PM, Andrew Rybchenko wrote: From: Dilshod Urazov VLAN tag insertion should be in Tx prepare, not in Tx burst functions. One of Tx prepare goals is to be able to do preparations in advance (possibliy on different CPU core) and then transmit it fast. Also Tx prepare can report t

Re: [dpdk-dev] [PATCH v4 2/2] net/virtio: move VLAN tag insertion to Tx prepare

2019-06-17 Thread Tiwei Bie
On Mon, Jun 17, 2019 at 12:31:38PM +0100, Andrew Rybchenko wrote: > From: Dilshod Urazov > > VLAN tag insertion should be in Tx prepare, not in Tx burst functions. > One of Tx prepare goals is to be able to do preparations in advance > (possibliy on different CPU core) and then transmit it fast.

[dpdk-dev] [PATCH v4 2/2] net/virtio: move VLAN tag insertion to Tx prepare

2019-06-17 Thread Andrew Rybchenko
From: Dilshod Urazov VLAN tag insertion should be in Tx prepare, not in Tx burst functions. One of Tx prepare goals is to be able to do preparations in advance (possibliy on different CPU core) and then transmit it fast. Also Tx prepare can report that a packet does not pass Tx offloads check. E.