Re: [dpdk-dev] [PATCH v4 20/22] net/atlantic: LED control DPDK and private APIs

2018-10-10 Thread Ferruh Yigit
On 10/10/2018 2:35 PM, Igor Russkikh wrote: > Hi Ferruh, > >>> +int rte_pmd_atl_dev_led_control(int port, int control); >> >> What is the intention here, making PMD specific public API? >> If so .map file is missing but we discourage using PMD specific APIs, >> >> can't it be possible to extend ex

Re: [dpdk-dev] [PATCH v4 20/22] net/atlantic: LED control DPDK and private APIs

2018-10-10 Thread Igor Russkikh
Hi Ferruh, >> +int rte_pmd_atl_dev_led_control(int port, int control); > > What is the intention here, making PMD specific public API? > If so .map file is missing but we discourage using PMD specific APIs, > > can't it be possible to extend exiting led related dev_ops in a generic way to > cove

Re: [dpdk-dev] [PATCH v4 20/22] net/atlantic: LED control DPDK and private APIs

2018-10-10 Thread Ferruh Yigit
On 10/9/2018 10:32 AM, Igor Russkikh wrote: > Signed-off-by: Igor Russkikh > Signed-off-by: Pavel Belous <...> > +/** > + * This is a custom API for adapter's LED controls. > + * > + * @param dev > + * Ethernet device to apply control to > + * @param control > + * 6 bit value (3 leds each 2

[dpdk-dev] [PATCH v4 20/22] net/atlantic: LED control DPDK and private APIs

2018-10-09 Thread Igor Russkikh
Signed-off-by: Igor Russkikh Signed-off-by: Pavel Belous --- drivers/net/atlantic/Makefile | 4 +++ drivers/net/atlantic/atl_ethdev.c | 53 + drivers/net/atlantic/atl_ethdev.h | 3 ++ drivers/net/atlantic/meson.build| 3 ++ drivers