Re: [dpdk-dev] [PATCH v4 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-10-05 Thread Rao, Nikhil
On 10/2/2017 4:09 PM, Jerin Jacob wrote: -Original Message- Date: Mon, 2 Oct 2017 15:58:56 +0530 From: "Rao, Nikhil" To: Jerin Jacob CC: bruce.richard...@intel.com, gage.e...@intel.com, dev@dpdk.org, tho...@monjalon.net, harry.van.haa...@intel.com, hemant.agra...@nxp.com, nipun.gu.

Re: [dpdk-dev] [PATCH v4 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-10-05 Thread Rao, Nikhil
On 10/3/2017 7:22 PM, Jerin Jacob wrote: -Original Message- Date: Sun, 24 Sep 2017 23:46:51 +0530 From: "Rao, Nikhil" To: Jerin Jacob CC: bruce.richard...@intel.com, gage.e...@intel.com, dev@dpdk.org, tho...@monjalon.net, harry.van.haa...@intel.com, hemant.agra...@nxp.com, nipun.gu

Re: [dpdk-dev] [PATCH v4 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-10-03 Thread Jerin Jacob
-Original Message- > Date: Sun, 24 Sep 2017 23:46:51 +0530 > From: "Rao, Nikhil" > To: Jerin Jacob > CC: bruce.richard...@intel.com, gage.e...@intel.com, dev@dpdk.org, > tho...@monjalon.net, harry.van.haa...@intel.com, hemant.agra...@nxp.com, > nipun.gu...@nxp.com, narender.vang...@inte

Re: [dpdk-dev] [PATCH v4 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-10-03 Thread Pavan Nikhilesh Bhagavatula
On Sat, Sep 23, 2017 at 05:05:21PM +0530, Rao, Nikhil wrote: Hi Nikhil, > On 9/21/2017 9:13 PM, Pavan Nikhilesh Bhagavatula wrote: > >Hi Nikhil, > > > >Few comments Inline > > > > > > + * - 0: Success, statistics reset successfully. > > > >Invalid description. > > Thanks Pavan, for catching these

Re: [dpdk-dev] [PATCH v4 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-10-02 Thread Jerin Jacob
-Original Message- > Date: Mon, 2 Oct 2017 15:58:56 +0530 > From: "Rao, Nikhil" > To: Jerin Jacob > CC: bruce.richard...@intel.com, gage.e...@intel.com, dev@dpdk.org, > tho...@monjalon.net, harry.van.haa...@intel.com, hemant.agra...@nxp.com, > nipun.gu...@nxp.com, narender.vang...@intel

Re: [dpdk-dev] [PATCH v4 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-10-02 Thread Rao, Nikhil
On 9/25/2017 8:29 AM, Rao, Nikhil wrote: On 9/24/2017 11:46 PM, Rao, Nikhil wrote: On 9/22/2017 2:40 PM, Jerin Jacob wrote: When we worked on a prototype, we figured out that we need a separate event type for RX adapter. Probably RTE_EVENT_TYPE_ETHDEV_RX_ADAPTER? The Reason is: - In the HW ba

Re: [dpdk-dev] [PATCH v4 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-10-02 Thread Rao, Nikhil
On 9/22/2017 11:38 AM, santosh wrote: In general api comment: Fix missing param definition like *service_id* above and pl. remove other unnecessary params description from api above. OK. +static inline int +valid_id(uint8_t id) +{ + return id < RTE_MAX_EVENT_ETH_RX_ADAPTER_INSTANCE

Re: [dpdk-dev] [PATCH v4 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-09-24 Thread Rao, Nikhil
On 9/24/2017 11:46 PM, Rao, Nikhil wrote: On 9/22/2017 2:40 PM, Jerin Jacob wrote: When we worked on a prototype, we figured out that we need a separate event type for RX adapter. Probably RTE_EVENT_TYPE_ETHDEV_RX_ADAPTER? The Reason is: - In the HW based Rx adapter case, the packet are coming

Re: [dpdk-dev] [PATCH v4 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-09-24 Thread Rao, Nikhil
On 9/22/2017 2:40 PM, Jerin Jacob wrote: -Original Message- Date: Fri, 22 Sep 2017 02:47:13 +0530 From: Nikhil Rao To: jerin.ja...@caviumnetworks.com, bruce.richard...@intel.com CC: gage.e...@intel.com, dev@dpdk.org, tho...@monjalon.net, harry.van.haa...@intel.com, hemant.agra...@nxp.

Re: [dpdk-dev] [PATCH v4 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-09-23 Thread Rao, Nikhil
On 9/21/2017 9:13 PM, Pavan Nikhilesh Bhagavatula wrote: Hi Nikhil, Few comments Inline + * - 0: Success, statistics reset successfully. Invalid description. Thanks Pavan, for catching these, will fix. + * - <0: Error code on failure, if the adapter doesn't use a rte_service + * f

Re: [dpdk-dev] [PATCH v4 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-09-22 Thread Jerin Jacob
-Original Message- > Date: Fri, 22 Sep 2017 02:47:13 +0530 > From: Nikhil Rao > To: jerin.ja...@caviumnetworks.com, bruce.richard...@intel.com > CC: gage.e...@intel.com, dev@dpdk.org, tho...@monjalon.net, > harry.van.haa...@intel.com, hemant.agra...@nxp.com, nipun.gu...@nxp.com, > narend

Re: [dpdk-dev] [PATCH v4 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-09-21 Thread santosh
On Friday 22 September 2017 02:47 AM, Nikhil Rao wrote: > Add common APIs for configuring packet transfer from ethernet Rx > queues to event devices across HW & SW packet transfer mechanisms. > A detailed description of the adapter is contained in the header's > comments. > > The adapter implement

Re: [dpdk-dev] [PATCH v4 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-09-21 Thread Pavan Nikhilesh Bhagavatula
Hi Nikhil, Few comments Inline On Fri, Sep 22, 2017 at 02:47:13AM +0530, Nikhil Rao wrote: > Add common APIs for configuring packet transfer from ethernet Rx > queues to event devices across HW & SW packet transfer mechanisms. > A detailed description of the adapter is contained in the header's >

[dpdk-dev] [PATCH v4 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-09-21 Thread Nikhil Rao
Add common APIs for configuring packet transfer from ethernet Rx queues to event devices across HW & SW packet transfer mechanisms. A detailed description of the adapter is contained in the header's comments. The adapter implementation uses eventdev PMDs to configure the packet transfer if HW supp