Re: [dpdk-dev] [PATCH v4 3/8] eal: introduce memory management wrappers

2020-05-05 Thread Burakov, Anatoly
On 01-May-20 8:00 PM, Dmitry Kozlyuk wrote: Thanks for pointing out the errors, see some comments inline. On 2020-04-29 18:13 GMT+0100 Burakov, Anatoly wrote: On 29-Apr-20 12:50 AM, Dmitry Kozlyuk wrote: + * Reservation size. Must be a multiple of system page size. + * @param flags + * Res

Re: [dpdk-dev] [PATCH v4 3/8] eal: introduce memory management wrappers

2020-05-01 Thread Dmitry Kozlyuk
Thanks for pointing out the errors, see some comments inline. On 2020-04-29 18:13 GMT+0100 Burakov, Anatoly wrote: > On 29-Apr-20 12:50 AM, Dmitry Kozlyuk wrote: > > + * Reservation size. Must be a multiple of system page size. > > + * @param flags > > + * Reservation options, a combination of

Re: [dpdk-dev] [PATCH v4 3/8] eal: introduce memory management wrappers

2020-04-30 Thread Burakov, Anatoly
On 29-Apr-20 6:13 PM, Burakov, Anatoly wrote: @@ -547,10 +531,10 @@ rte_eal_memdevice_init(void)   int   rte_mem_lock_page(const void *virt)   { -    unsigned long virtual = (unsigned long)virt; -    int page_size = getpagesize(); -    unsigned long aligned = (virtual & ~(page_size - 1)); -    re

Re: [dpdk-dev] [PATCH v4 3/8] eal: introduce memory management wrappers

2020-04-29 Thread Burakov, Anatoly
On 29-Apr-20 12:50 AM, Dmitry Kozlyuk wrote: Introduce OS-independent wrappers for memory management operations used across DPDK and specifically in common code of EAL: * rte_mem_map() * rte_mem_unmap() * rte_get_page_size() * rte_mem_lock() Windows uses different APIs for memory mapping and re

[dpdk-dev] [PATCH v4 3/8] eal: introduce memory management wrappers

2020-04-28 Thread Dmitry Kozlyuk
Introduce OS-independent wrappers for memory management operations used across DPDK and specifically in common code of EAL: * rte_mem_map() * rte_mem_unmap() * rte_get_page_size() * rte_mem_lock() Windows uses different APIs for memory mapping and reservation, while Unices reserve memory by mappi