[dpdk-dev] [PATCH v4 5/8] sample/vhost:remove ip_hdr structure defination

On Wed, Nov 11, 2015 at 02:40:43PM +0800, Jijiang Liu wrote: > Remove the ip_hdr structure defination. Even for such simple patch, you need state why. Stating that "remove ip_hdr structure defination because we already have that in rte_ip.h" will definitely let others to accept your patch eaiser.

[dpdk-dev] [PATCH v4 5/8] sample/vhost:remove ip_hdr structure defination

Remove the ip_hdr structure defination. Signed-off-by: Jijiang Liu --- examples/vhost/main.c | 15 +-- 1 files changed, 1 insertions(+), 14 deletions(-) diff --git a/examples/vhost/main.c b/examples/vhost/main.c index c081b18..044c680 100644 --- a/examples/vhost/main.c +++

[dpdk-dev] [PATCH v4 5/8] sample/vhost:remove ip_hdr structure defination

2015-11-11 16:34, Yuanhan Liu: > On Wed, Nov 11, 2015 at 02:40:43PM +0800, Jijiang Liu wrote: > > Remove the ip_hdr structure defination. > > Even for such simple patch, you need state why. Stating that > "remove ip_hdr structure defination because we already have > that in rte_ip.h" will